From: Stefan Reiter <s.reiter@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH 0/7] More flocking and race elimination
Date: Tue, 4 Aug 2020 12:41:58 +0200 [thread overview]
Message-ID: <20200804104205.29540-1-s.reiter@proxmox.com> (raw)
The previous series[0] already fixed some bugs, but it also introduced some new
ones, e.g. incomplete but not running backups were unable to be removed.
This is the next step to race-free™ backups, this time going all-in on flocks.
Patches 1 and 2 are technically unrelated (though necessary), so could be
committed standalone.
The last patch introduces locking for base backups, but also re-writes the
previous (unnecessarily complex) base-snapshot existance check, which is
therefor reverted in patch 6.
[0] https://lists.proxmox.com/pipermail/pbs-devel/2020-July/000233.html
proxmox-backup: Stefan Reiter (7):
finish_backup: mark backup as finished only after checks have passed
backup: only allow finished backups as base snapshot
datastore: prevent in-use deletion with locks instead of heuristic
prune: also check backup snapshot locks
backup: flock snapshot on backup start
Revert "backup: ensure base snapshots are still available after
backup"
backup: lock base snapshot and ensure existance on finish
src/api2/admin/datastore.rs | 2 +-
src/api2/backup.rs | 16 +++++---
src/api2/backup/environment.rs | 21 +++--------
src/backup/backup_info.rs | 65 +++++++++++++++++++++++++++++----
src/backup/datastore.rs | 62 +++++++++++--------------------
src/backup/prune.rs | 48 +++++++++++++++++-------
src/bin/proxmox-backup-proxy.rs | 2 +-
src/client/pull.rs | 2 +-
tests/prune.rs | 6 ++-
9 files changed, 136 insertions(+), 88 deletions(-)
--
2.20.1
next reply other threads:[~2020-08-04 10:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-04 10:41 Stefan Reiter [this message]
2020-08-04 10:41 ` [pbs-devel] [PATCH proxmox-backup 1/7] finish_backup: mark backup as finished only after checks have passed Stefan Reiter
2020-08-06 4:39 ` [pbs-devel] applied: " Dietmar Maurer
2020-08-04 10:42 ` [pbs-devel] [PATCH proxmox-backup 2/7] backup: only allow finished backups as base snapshot Stefan Reiter
2020-08-06 4:45 ` Dietmar Maurer
2020-08-06 7:58 ` Stefan Reiter
2020-08-07 5:40 ` [pbs-devel] applied: " Dietmar Maurer
2020-08-04 10:42 ` [pbs-devel] [PATCH proxmox-backup 3/7] datastore: prevent in-use deletion with locks instead of heuristic Stefan Reiter
2020-08-06 4:51 ` Dietmar Maurer
2020-08-04 10:42 ` [pbs-devel] [PATCH proxmox-backup 4/7] prune: also check backup snapshot locks Stefan Reiter
2020-08-05 7:23 ` Fabian Ebner
2020-08-05 8:34 ` Stefan Reiter
2020-08-04 10:42 ` [pbs-devel] [PATCH proxmox-backup 5/7] backup: flock snapshot on backup start Stefan Reiter
2020-08-04 10:42 ` [pbs-devel] [PATCH proxmox-backup 6/7] Revert "backup: ensure base snapshots are still available after backup" Stefan Reiter
2020-08-04 10:42 ` [pbs-devel] [PATCH proxmox-backup 7/7] backup: lock base snapshot and ensure existance on finish Stefan Reiter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200804104205.29540-1-s.reiter@proxmox.com \
--to=s.reiter@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox