public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 4/4] datastore: allow browsing signed pxar files
Date: Mon,  3 Aug 2020 14:10:46 +0200	[thread overview]
Message-ID: <20200803121046.3623216-5-f.gruenbichler@proxmox.com> (raw)
In-Reply-To: <20200803121046.3623216-1-f.gruenbichler@proxmox.com>

just because we can't verify the signature, does not mean the contents
are not accessible. it might make sense to make it obvious with a hint
or click-through warning that no signature verification can take place
or this and downloading.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---
 www/DataStoreContent.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/DataStoreContent.js b/www/DataStoreContent.js
index e8690486..62e57817 100644
--- a/www/DataStoreContent.js
+++ b/www/DataStoreContent.js
@@ -505,7 +505,7 @@ Ext.define('PBS.DataStoreContent', {
 			return !(data.leaf &&
 			    data.filename &&
 			    data.filename.endsWith('pxar.didx') &&
-			    data['crypt-mode'] < 2);
+			    data['crypt-mode'] < 3);
 		    }
 		},
 	    ]
-- 
2.20.1





  parent reply	other threads:[~2020-08-03 12:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-03 12:10 [pbs-devel] [PATCH proxmox-backup 0/4] add missing digest verification Fabian Grünbichler
2020-08-03 12:10 ` [pbs-devel] [PATCH proxmox-backup 1/4] blobs: attempt to verify on decode when possible Fabian Grünbichler
2020-08-03 12:10 ` [pbs-devel] [PATCH proxmox-backup 2/4] sync: verify chunk size and digest, if possible Fabian Grünbichler
2020-08-03 12:10 ` [pbs-devel] [PATCH proxmox-backup 3/4] sync: verify size and checksum of pulled archives Fabian Grünbichler
2020-08-03 12:10 ` Fabian Grünbichler [this message]
2020-08-04  5:29 ` [pbs-devel] applied: [PATCH proxmox-backup 0/4] add missing digest verification Dietmar Maurer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200803121046.3623216-5-f.gruenbichler@proxmox.com \
    --to=f.gruenbichler@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal