From: Stefan Reiter <s.reiter@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH 0/5] fix #2881: protect base snapshots and avoid races
Date: Wed, 29 Jul 2020 14:33:09 +0200 [thread overview]
Message-ID: <20200729123314.10049-1-s.reiter@proxmox.com> (raw)
Avoid races with GC and between different concurrent backups by limiting the
number of concurrent backups per group to 1 and forbidding the deletion of the
previous finished backup, if a new one is currently running.
Fixes several issues that could lead to failed backups, or even worse,
"successful" backups that were really missing chunks.
proxmox-backup: Stefan Reiter (5):
fix typo: avgerage to average
datastore: prevent deletion of snaps in use as "previous backup"
tools: add nonblocking mode to lock_file
backup: use flock on backup group to forbid multiple backups at once
backup: ensure base snapshots are still available after backup
src/api2/admin/datastore.rs | 4 +--
src/api2/backup.rs | 12 +++++---
src/api2/backup/environment.rs | 23 +++++++++++++--
src/backup/backup_info.rs | 51 ++++++++++++++++++++++++++++++++-
src/backup/datastore.rs | 43 +++++++++++++++++++++++++--
src/backup/prune.rs | 2 +-
src/bin/proxmox-backup-proxy.rs | 2 +-
src/client/backup_writer.rs | 2 +-
src/client/pull.rs | 4 +--
src/tools.rs | 13 +++++++++
10 files changed, 140 insertions(+), 16 deletions(-)
--
2.20.1
next reply other threads:[~2020-07-29 12:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 12:33 Stefan Reiter [this message]
2020-07-29 12:33 ` [pbs-devel] [PATCH proxmox-backup 1/5] fix typo: avgerage to average Stefan Reiter
2020-07-30 5:25 ` [pbs-devel] applied: " Dietmar Maurer
2020-07-29 12:33 ` [pbs-devel] [PATCH proxmox-backup 2/5] datastore: prevent deletion of snaps in use as "previous backup" Stefan Reiter
2020-07-30 6:37 ` [pbs-devel] applied: " Dietmar Maurer
2020-07-30 6:40 ` [pbs-devel] " Fabian Grünbichler
2020-07-29 12:33 ` [pbs-devel] [PATCH proxmox-backup 3/5] tools: add nonblocking mode to lock_file Stefan Reiter
2020-07-30 6:23 ` [pbs-devel] applied: " Dietmar Maurer
2020-07-29 12:33 ` [pbs-devel] [PATCH proxmox-backup 4/5] backup: use flock on backup group to forbid multiple backups at once Stefan Reiter
2020-07-30 5:50 ` Dietmar Maurer
2020-07-30 7:36 ` Stefan Reiter
2020-07-30 7:41 ` Dietmar Maurer
2020-07-30 8:02 ` Stefan Reiter
2020-07-30 6:38 ` [pbs-devel] applied: " Dietmar Maurer
2020-07-29 12:33 ` [pbs-devel] [PATCH proxmox-backup 5/5] backup: ensure base snapshots are still available after backup Stefan Reiter
2020-07-30 6:38 ` [pbs-devel] applied: " Dietmar Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200729123314.10049-1-s.reiter@proxmox.com \
--to=s.reiter@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox