public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stefan Reiter <s.reiter@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 2/2] ui: fix in-progress snapshots always showing as "Encrypted"
Date: Tue, 28 Jul 2020 14:32:11 +0200	[thread overview]
Message-ID: <20200728123211.9276-2-s.reiter@proxmox.com> (raw)
In-Reply-To: <20200728123211.9276-1-s.reiter@proxmox.com>

We can't know if they are encrypted or not when they're not even
finished yet.

Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
---
 www/DataStoreContent.js | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/www/DataStoreContent.js b/www/DataStoreContent.js
index 1c08f56a..e8690486 100644
--- a/www/DataStoreContent.js
+++ b/www/DataStoreContent.js
@@ -549,6 +549,9 @@ Ext.define('PBS.DataStoreContent', {
 	    header: gettext('Encrypted'),
 	    dataIndex: 'crypt-mode',
 	    renderer: (v, meta, record) => {
+		if (record.data.size === undefined || record.data.size === null) {
+		    return '';
+		}
 		if (v === -1) {
 		    return '';
 		}
-- 
2.20.1





  reply	other threads:[~2020-07-28 12:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-28 12:32 [pbs-devel] [PATCH proxmox-backup 1/2] ui: fix error when reloading DataStoreContent Stefan Reiter
2020-07-28 12:32 ` Stefan Reiter [this message]
2020-07-29  5:13   ` [pbs-devel] applied: [PATCH proxmox-backup 2/2] ui: fix in-progress snapshots always showing as "Encrypted" Dietmar Maurer
2020-07-29  5:13 ` [pbs-devel] applied: [PATCH proxmox-backup 1/2] ui: fix error when reloading DataStoreContent Dietmar Maurer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200728123211.9276-2-s.reiter@proxmox.com \
    --to=s.reiter@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal