* [pbs-devel] [PATCH proxmox-backup-qemu] ignore missing or bad previous index
@ 2020-07-09 12:12 Stefan Reiter
2020-07-09 12:22 ` [pbs-devel] applied: " Dietmar Maurer
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Reiter @ 2020-07-09 12:12 UTC (permalink / raw)
To: pbs-devel
This is not a fatal condition, it just means that we cannot do
incremental backups client-side. This can happen if a new disk was added
the a VM since the last backup for example.
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
---
src/commands.rs | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/commands.rs b/src/commands.rs
index 9c21702..6f26324 100644
--- a/src/commands.rs
+++ b/src/commands.rs
@@ -114,7 +114,11 @@ pub(crate) async fn register_image(
let index = match manifest {
Some(manifest) => {
- Some(client.download_previous_fixed_index(&archive_name, &manifest, known_chunks.clone()).await?)
+ match client.download_previous_fixed_index(&archive_name, &manifest, known_chunks.clone()).await {
+ Ok(index) => Some(index),
+ // not having a previous index is not fatal, so ignore errors
+ Err(_) => None
+ }
},
None => None
};
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pbs-devel] applied: [PATCH proxmox-backup-qemu] ignore missing or bad previous index
2020-07-09 12:12 [pbs-devel] [PATCH proxmox-backup-qemu] ignore missing or bad previous index Stefan Reiter
@ 2020-07-09 12:22 ` Dietmar Maurer
0 siblings, 0 replies; 2+ messages in thread
From: Dietmar Maurer @ 2020-07-09 12:22 UTC (permalink / raw)
To: Proxmox Backup Server development discussion, Stefan Reiter
applied, thanks!
> On 07/09/2020 2:12 PM Stefan Reiter <s.reiter@proxmox.com> wrote:
>
>
> This is not a fatal condition, it just means that we cannot do
> incremental backups client-side. This can happen if a new disk was added
> the a VM since the last backup for example.
>
> Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
> ---
> src/commands.rs | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/src/commands.rs b/src/commands.rs
> index 9c21702..6f26324 100644
> --- a/src/commands.rs
> +++ b/src/commands.rs
> @@ -114,7 +114,11 @@ pub(crate) async fn register_image(
>
> let index = match manifest {
> Some(manifest) => {
> - Some(client.download_previous_fixed_index(&archive_name, &manifest, known_chunks.clone()).await?)
> + match client.download_previous_fixed_index(&archive_name, &manifest, known_chunks.clone()).await {
> + Ok(index) => Some(index),
> + // not having a previous index is not fatal, so ignore errors
> + Err(_) => None
> + }
> },
> None => None
> };
> --
> 2.20.1
>
>
>
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-09 12:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-09 12:12 [pbs-devel] [PATCH proxmox-backup-qemu] ignore missing or bad previous index Stefan Reiter
2020-07-09 12:22 ` [pbs-devel] applied: " Dietmar Maurer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox