public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup] tasks: bump archive to 100k entries
Date: Wed,  8 Jul 2020 10:04:24 +0200	[thread overview]
Message-ID: <20200708080424.1140125-1-f.gruenbichler@proxmox.com> (raw)

1000 are way too few, but it probably makes sense to make this value
configurable in the future.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---
or even think about encoding the datastore in the TaskInfo/UPID (almost
all regular tasks are datastore specific), which would allow setting a
default and per-datastore limit.

 src/server/worker_task.rs | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/server/worker_task.rs b/src/server/worker_task.rs
index 72c594e6..89c0e115 100644
--- a/src/server/worker_task.rs
+++ b/src/server/worker_task.rs
@@ -304,9 +304,10 @@ fn update_active_workers(new_upid: Option<&UPID>) -> Result<Vec<TaskListInfo>, E
 
     // assemble list without duplicates
     // we include all active tasks,
-    // and fill up to 1000 entries with finished tasks
+    // and fill up to 100000 entries with finished tasks
+    // TODO: make configurable ?
 
-    let max = 1000;
+    let max = 100000;
 
     let mut task_hash = HashMap::new();
 
-- 
2.20.1





                 reply	other threads:[~2020-07-08  8:11 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200708080424.1140125-1-f.gruenbichler@proxmox.com \
    --to=f.gruenbichler@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal