public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	Stefan Hanreich <s.hanreich@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup v2] fix #4301: correctly pass rate limit parameters to API
Date: Fri, 21 Oct 2022 17:31:07 +0200	[thread overview]
Message-ID: <1f2a4db3-1042-0d1f-c23b-6b03fbabd44b@proxmox.com> (raw)
In-Reply-To: <20221020133630.376542-1-s.hanreich@proxmox.com>

FYI, missing a (short) changelog to the previous patch reviosion, namely...

Am 20/10/2022 um 15:36 schrieb Stefan Hanreich:
> With the old code the rate limit parameters got passed in their own
> dictionary under the limit key, but the API expects the rate-limit
> settings as top-level keys. This commit correctly sets the rate-limit
> parameters so the API actually uses them.
> 
> Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
> ---

.. here

https://pve.proxmox.com/wiki/Developer_Documentation#Versioned_Patches

>  src/bin/proxmox-backup-manager.rs | 13 +++++++++++--
>  1 file changed, 11 insertions(+), 2 deletions(-)
> 
> diff --git a/src/bin/proxmox-backup-manager.rs b/src/bin/proxmox-backup-manager.rs




      parent reply	other threads:[~2022-10-21 15:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-20 13:36 Stefan Hanreich
2022-10-20 14:06 ` [pbs-devel] applied: " Wolfgang Bumiller
2022-10-21 15:31 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1f2a4db3-1042-0d1f-c23b-6b03fbabd44b@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    --cc=s.hanreich@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal