From: Hannes Laimer <h.laimer@proxmox.com>
To: Dietmar Maurer <dietmar@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup v2 0/3] close #3612: allow config of SSL cipher-suites for proxy
Date: Wed, 5 Jan 2022 14:53:11 +0100 [thread overview]
Message-ID: <1f14bae7-fa70-cc68-c641-77025b667bb6@proxmox.com> (raw)
In-Reply-To: <1064698276.2596.1641374841394@webmail.proxmox.com>
Am 05.01.22 um 10:27 schrieb Dietmar Maurer:
>
>> But this does not throw an error:
>>
>> # proxmox-backup-manager node update --cipher-suites-tls2 asdasd,BBB,BBB.XZY,ECDHE-RSA-AES256-SHA
>>
>> Seems ssl simply ignores all unknown ciphers. The only error is when the list contains no known cipher.
>
> I wonder if we can hardcode the list of available values and parse it correctly? Allowed values would be:
>
> # openssl ciphers -tls1_2
> # openssl ciphers -tls1_3
Yes, but just hardcoding the list probably wont be enough since the
string is allowed to contain !,+,- and some other things[1]. This check
was mostly thought to check if the proxy would still start with the
given chiphers, not if the given string was valid. Also I'm not sure if
we should be more strict than openssl[2].
[1] https://www.openssl.org/docs/man1.1.1/man1/ciphers.html
[2]
https://github.com/openssl/openssl/blob/master/doc/man3/SSL_CTX_set_cipher_list.pod#notes
next prev parent reply other threads:[~2022-01-05 13:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-05 9:27 Dietmar Maurer
2022-01-05 13:53 ` Hannes Laimer [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-01-05 15:16 Dietmar Maurer
2022-01-05 9:09 Dietmar Maurer
2022-01-05 8:55 Dietmar Maurer
2022-01-04 11:48 Hannes Laimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f14bae7-fa70-cc68-c641-77025b667bb6@proxmox.com \
--to=h.laimer@proxmox.com \
--cc=dietmar@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox