From: Gabriel Goller <g.goller@proxmox.com>
To: "Thomas Lamprecht" <t.lamprecht@proxmox.com>,
"Proxmox Backup Server development discussion"
<pbs-devel@lists.proxmox.com>,
"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: Re: [pbs-devel] [PATCH v2 proxmox{, -backup} 0/2] Move ProcessLocker to tmpfs
Date: Wed, 6 Dec 2023 15:46:08 +0100 [thread overview]
Message-ID: <1efc8388-0c8f-4b34-9ba6-e0c8d52ab93c@proxmox.com> (raw)
In-Reply-To: <658c5de3-d130-42d5-951c-9ccd58daa0fe@proxmox.com>
On 12/6/23 15:36, Thomas Lamprecht wrote:
> Am 06/12/2023 um 14:41 schrieb Fabian Grünbichler:
>> [..]
> Wolfgang and I discussed this last week or so, and we'd use a flag living
> in `/run/proxmox-backup` touched via proxmox-backup-server.postinst on
> upgrade to signal that the new locking should not be used yet, after reboot
> all old daemons are gone and so is the flag, so the new locking can be used.
>
> Manual downgrades we don't care for, as those need special attention anyway.
> The duplicate code can then be ripped out in the next major release.
>
> Wolfgang has a PoC about this on his staff repo IIRC.
We should also add a section in the upgrade guide on how to upgrade
*without*
rebooting, so stopping all old processes, removing the flag manually,
updating,
then starting the new process. (I'd guess a lot of people don't want to
reboot)
next prev parent reply other threads:[~2023-12-06 14:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 13:28 Gabriel Goller
2023-12-06 13:28 ` [pbs-devel] [PATCH v2 proxmox 1/2] process_locker: use ofd locking Gabriel Goller
2023-12-06 13:28 ` [pbs-devel] [PATCH v2 proxmox-backup 2/2] datastore: store datastore lock on tmpfs Gabriel Goller
2023-12-06 13:41 ` [pbs-devel] [PATCH v2 proxmox{, -backup} 0/2] Move ProcessLocker to tmpfs Fabian Grünbichler
2023-12-06 13:56 ` Gabriel Goller
2023-12-06 14:14 ` Fabian Grünbichler
2023-12-06 14:21 ` Gabriel Goller
2023-12-06 14:33 ` Fabian Grünbichler
2023-12-06 14:36 ` Thomas Lamprecht
2023-12-06 14:46 ` Gabriel Goller [this message]
2023-12-06 14:58 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1efc8388-0c8f-4b34-9ba6-e0c8d52ab93c@proxmox.com \
--to=g.goller@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox