From: Gabriel Goller <g.goller@proxmox.com>
To: Lukas Wagner <l.wagner@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH v3 proxmox-backup 2/3] node: status: added bootmode
Date: Mon, 27 Nov 2023 11:52:04 +0100 [thread overview]
Message-ID: <1ef14b2b-8f45-46d1-9861-5fe437cbb606@proxmox.com> (raw)
In-Reply-To: <2e8e5583-6d5f-4387-b67d-b5db469f43a4@proxmox.com>
On 11/27/23 11:39, Lukas Wagner wrote:
>
>
> On 11/27/23 11:16, Gabriel Goller wrote:
>> diff --git a/www/panel/NodeInfo.js b/www/panel/NodeInfo.js
>> index 2551c9a5..907abe3a 100644
>> --- a/www/panel/NodeInfo.js
>> +++ b/www/panel/NodeInfo.js
>> @@ -147,6 +147,22 @@ Ext.define('PBS.NodeInfoPanel', {
>> textField: 'kversion',
>> value: '',
>> },
>> + {
>> + colspan: 2,
>> + title: gettext('Boot Mode'),
>> + printBar: false,
>> + textField: 'boot-info',
>> + renderer: boot => {
>> + console.log(boot);
>
> Left-over debug-print? :) (also indented wrong using only spaces)
Oof, right. Submitted a new patch!
>
>> + if (boot.mode === 'legacy-bios') {
>> + return 'Legacy BIOS';
>> + } else if (boot.mode === 'efi') {
>> + return `EFI${boot.secureboot ? ' (Secure Boot)' : ''}`;
>> + }
>> + return Proxmox.Utils.unknownText;
>> + },
>> + value: '',
>> + },
>> {
>> xtype: 'pmxNodeInfoRepoStatus',
>> itemId: 'repositoryStatus',
>
next prev parent reply other threads:[~2023-11-27 10:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-27 10:16 [pbs-devel] [PATCH v3 proxmox{, -backup} 0/3] Add boot_mode, improve kernel version Gabriel Goller
2023-11-27 10:16 ` [pbs-devel] [PATCH v3 proxmox 1/3] sys: add function to get boot_mode Gabriel Goller
2023-11-27 12:48 ` Wolfgang Bumiller
2023-11-27 13:20 ` Gabriel Goller
2023-11-27 10:16 ` [pbs-devel] [PATCH v3 proxmox-backup 2/3] node: status: added bootmode Gabriel Goller
2023-11-27 10:39 ` Lukas Wagner
2023-11-27 10:52 ` Gabriel Goller [this message]
2023-11-27 10:16 ` [pbs-devel] [PATCH v3 proxmox-backup 3/3] node: status: declutter kernel-version Gabriel Goller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ef14b2b-8f45-46d1-9861-5fe437cbb606@proxmox.com \
--to=g.goller@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox