From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>, Markus Frank <m.frank@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup v2] cli: add interactive confirmation for block device wipe
Date: Wed, 29 Nov 2023 15:04:27 +0100 [thread overview]
Message-ID: <1e3f3e28-0444-4731-b54b-42e58f4c189c@proxmox.com> (raw)
In-Reply-To: <20231129132018.117868-1-m.frank@proxmox.com>
Am 29/11/2023 um 14:20 schrieb Markus Frank:
> If stdin is a TTY, an interactive prompt is added to confirm the deletion
> of a block device, ensuring user verification before proceeding.
>
> Signed-off-by: Markus Frank <m.frank@proxmox.com>
> ---
> v2:
> * changed stdin_isatty() to std::io::stdin().is_terminal()
> * removed unnecessary eprint
> * do not loop if answer is not either y/Y or n/N
> * moved err inline in bail
>
> src/bin/proxmox_backup_manager/disk.rs | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
>
applied, but dropped the now useless loop in a follow-up and changed
the output target for the prompt message from stderr to stdout, thanks!
prev parent reply other threads:[~2023-11-29 14:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-29 13:20 [pbs-devel] " Markus Frank
2023-11-29 14:04 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e3f3e28-0444-4731-b54b-42e58f4c189c@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=m.frank@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox