Re: [pbs-devel] applied: [PATCH proxmox-backup 0/6] fix various s3 related ui/cli/doc issues

[Christian Ebner <c.ebner@proxmox.com>]

On 7/22/25 10:25 PM, Thomas Lamprecht wrote:
> Am 22.07.25 um 14:49 schrieb Christian Ebner:
>> This patch series is a followup to the s3 object store backend for
>> Proxmox Backup Server patch series found at:
>> https://lore.proxmox.com/pbs-devel/20250722101106.526438-1-c.ebner@proxmox.com/T/
>>
>> Most prominently, it moves the S3 endpoint configuration to the remotes,
>> splitting the remotes into tabs for the s3 configuration and the remote
>> Proxmox Backup Server configuration.
>>
>> The other patches mostly touch naming, preferring `endpoint` over
>> `client` for s3 endpoint configurations.
>>
>> Also, fixes a small ui issue found by Lukas during testing (thanks for
>> the report, still plan to refactor the whole datastore edit window as
>> promised once I find the time).
>>
>> The last patch improves ui by allowing the user to pass the https scheme
>> prefix to the endpoint in the ui, stripping it for the backend config.
>>
>> Christian Ebner (6):
>>    ui: add tabs for remotes and move s3 endpoint config to it
>>    ui: use S3 endpoint over S3 client for ui elements
>>    cli: use `endpoint` over `client` for s3 endpoint subcommands
>>    docs: use `endpoint` over `client` for the s3 endpoint configuration
>>    ui: default for s3 overwrite-in-use to be disabled
>>    ui: s3 client edit: allow for https scheme prefix in endpoint input
>>
>>   docs/storage.rst                     | 29 ++++++++-------
>>   src/bin/proxmox_backup_manager/s3.rs | 14 +++----
>>   www/Makefile                         |  1 +
>>   www/NavigationTree.js                |  8 +---
>>   www/config/RemoteView.js             |  2 +-
>>   www/config/RemotesOverview.js        | 55 ++++++++++++++++++++++++++++
>>   www/config/S3ClientView.js           |  2 +-
>>   www/form/S3ClientSelector.js         |  2 +-
>>   www/window/DataStoreEdit.js          |  6 ++-
>>   www/window/S3ClientEdit.js           |  6 ++-
>>   10 files changed, 92 insertions(+), 33 deletions(-)
>>   create mode 100644 www/config/RemotesOverview.js
>>
> 
> 
> applied, thanks!

I see the first patch (tabs for remotes) was not applied, the Remotes 
and S3 Endpoints still separate in the side menu.

Was this intentional?


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel