From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup 3/7] ui: implment task history limit and make it configurable
Date: Mon, 5 Oct 2020 16:44:57 +0200 [thread overview]
Message-ID: <1cfbeed8-4007-4eb7-3f20-600a1dd978d8@proxmox.com> (raw)
In-Reply-To: <20201005134317.12425-3-d.csapak@proxmox.com>
s/implment/implement/
On 05.10.20 15:43, Dominik Csapak wrote:
> @@ -234,7 +235,10 @@ Ext.define('PBS.Dashboard', {
> },
> },
>
> - title: gettext('Dashboard') + ' - WIP',
> + bind: {
> + title: gettext('Dashboard') + ' (' +
> + Ext.String.format(gettext('{0} days'), '{days}') + ')',
> + },
would not do that, this suggests all dashboard data is from that days,
rather only set the title in the graphs where it actually affects things.
like, for example, ...
>
> layout: {
> type: 'column',
> @@ -248,6 +252,13 @@ Ext.define('PBS.Dashboard', {
> margin: '0 20 20 0',
> },
>
> + tools: [
> + {
> + type: 'gear',
> + handler: 'openDashboardOptions',
> + },
> + ],
> +
> scrollable: true,
>
> items: [
> diff --git a/www/dashboard/LongestTasks.js b/www/dashboard/LongestTasks.js
> index f74e768e..20cf1183 100644
> --- a/www/dashboard/LongestTasks.js
> +++ b/www/dashboard/LongestTasks.js
> @@ -2,7 +2,7 @@ Ext.define('PBS.LongestTasks', {
> extend: 'Ext.grid.Panel',
> alias: 'widget.pbsLongestTasks',
>
> - title: gettext('Longest Tasks (last Month)'),
> + title: gettext('Longest Tasks'),
... here (see above)
>
> hideHeaders: true,
> rowLines: false,
> diff --git a/www/dashboard/TaskSummary.js b/www/dashboard/TaskSummary.js
> index 5e2a4b13..6f2e1d99 100644
> --- a/www/dashboard/TaskSummary.js
> +++ b/www/dashboard/TaskSummary.js
> @@ -2,7 +2,7 @@ Ext.define('PBS.TaskSummary', {
> extend: 'Ext.panel.Panel',
> alias: 'widget.pbsTaskSummary',
>
> - title: gettext('Task Summary (last Month)'),
> + title: gettext('Task Summary'),
... and here (see above)
>
> controller: {
> xclass: 'Ext.app.ViewController',
>
next prev parent reply other threads:[~2020-10-05 14:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-05 13:43 [pbs-devel] [PATCH proxmox-backup 1/7] api2/types: add TaskStateType struct Dominik Csapak
2020-10-05 13:43 ` [pbs-devel] [PATCH proxmox-backup 2/7] api2/status: add type- and statusfilter to tasks api call Dominik Csapak
2020-10-05 13:43 ` [pbs-devel] [PATCH proxmox-backup 3/7] ui: implment task history limit and make it configurable Dominik Csapak
2020-10-05 14:44 ` Thomas Lamprecht [this message]
2020-10-05 13:43 ` [pbs-devel] [PATCH proxmox-backup 4/7] ui: refactor render_icon code Dominik Csapak
2020-10-05 14:52 ` [pbs-devel] applied: " Thomas Lamprecht
2020-10-05 13:43 ` [pbs-devel] [PATCH proxmox-backup 5/7] ui: Dashboard/TaskSummary: refactor types and title Dominik Csapak
2020-10-05 14:52 ` Thomas Lamprecht
2020-10-06 6:56 ` Dominik Csapak
2020-10-05 13:43 ` [pbs-devel] [PATCH proxmox-backup 6/7] ui: Dashboard/TaskSummary: add Verifies to the Summary Dominik Csapak
2020-10-05 13:43 ` [pbs-devel] [PATCH proxmox-backup 7/7] ui: Dashboard/TaskSummary: show task overlay when clicking on a count Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1cfbeed8-4007-4eb7-3f20-600a1dd978d8@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox