From: Friedrich Weber <f.weber@proxmox.com>
To: Lukas Wagner <l.wagner@proxmox.com>
Cc: pbs-devel@lists.proxmox.com
Subject: Re: [pbs-devel] [PATCH v4 proxmox-widget-toolkit 5/5] auth ui: fix `value not defined in enumeration` error
Date: Wed, 15 Feb 2023 09:10:39 +0100 [thread overview]
Message-ID: <1c87956c-06aa-61bc-8dc6-806b95b421ed@proxmox.com> (raw)
In-Reply-To: <20230214132652.749737-6-l.wagner@proxmox.com>
Can confirm that the error is gone now, and the realm settings are saved
as expected. Consider this
Tested-by: Friedrich Weber <f.weber@proxmox.com>
On 14/02/2023 14:26, Lukas Wagner wrote:
> ...when editing LDAP realm sync settings and only a single property is
> empty and thus to be deleted (e.g. values.delete = "filter").
>
> If `delete` is a simple string and not an array,
> `Proxmox.Utils.delete_if_default` simply creates a comma-separated list,
> (e.g. value.delete = "filter,sync-attributes").
>
> When the properties from the other panel are evaluated and added to the
> the `delete` property, comma-separated list format is not considered,
> leading to a final value for `delete` that could look like this:
> value.delete = {
> "server2",
> "comment",
> "filter,sync-attributes"
> }
>
> This commit fixes this by splitting `delete` in case it is a string.
>
> Reported-by: Friedrich Weber <f.weber@proxmox.com>
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
> src/window/AuthEditLDAP.js | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/src/window/AuthEditLDAP.js b/src/window/AuthEditLDAP.js
> index aa85c5d..3e8ce88 100644
> --- a/src/window/AuthEditLDAP.js
> +++ b/src/window/AuthEditLDAP.js
> @@ -243,6 +243,11 @@ Ext.define('Proxmox.panel.LDAPSyncInputPanel', {
> Proxmox.Utils.delete_if_default(values, 'sync-defaults-options');
> Proxmox.Utils.delete_if_default(values, 'sync-attributes');
>
> + // Force values.delete to be an array
> + if (typeof values.delete === 'string') {
> + values.delete = values.delete.split(',');
> + }
> +
> if (me.isCreate) {
> delete values.delete; // on create we cannot delete values
> }
next prev parent reply other threads:[~2023-02-15 8:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-14 13:26 [pbs-devel] [PATCH v4 proxmox-widget-toolkit 0/5] add LDAP realm support UI Lukas Wagner
2023-02-14 13:26 ` [pbs-devel] [PATCH v4 proxmox-widget-toolkit 1/5] auth ui: add LDAP realm edit panel Lukas Wagner
2023-02-14 13:26 ` [pbs-devel] [PATCH v4 proxmox-widget-toolkit 2/5] auth ui: add LDAP sync UI Lukas Wagner
2023-02-14 13:26 ` [pbs-devel] [PATCH v4 proxmox-widget-toolkit 3/5] auth ui: add `onlineHelp` for AuthEditLDAP Lukas Wagner
2023-02-14 13:26 ` [pbs-devel] [PATCH v4 proxmox-widget-toolkit 4/5] auth ui: add `firstname` and `lastname` sync-attribute fields Lukas Wagner
2023-02-14 13:26 ` [pbs-devel] [PATCH v4 proxmox-widget-toolkit 5/5] auth ui: fix `value not defined in enumeration` error Lukas Wagner
2023-02-15 8:10 ` Friedrich Weber [this message]
2023-03-14 8:22 ` [pbs-devel] [PATCH v4 proxmox-widget-toolkit 0/5] add LDAP realm support UI Lukas Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c87956c-06aa-61bc-8dc6-806b95b421ed@proxmox.com \
--to=f.weber@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox