From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Cc: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: [pbs-devel] partiall-applied: [pve-devel] [PATCH proxmox-backup/common/storage/wt v2] improve file-restore timeout behaviour
Date: Wed, 27 Apr 2022 19:43:37 +0200 [thread overview]
Message-ID: <1c6f3e5d-8079-538d-1035-67940df3fffc@proxmox.com> (raw)
In-Reply-To: <20220426101401.3216096-1-d.csapak@proxmox.com>
On 26.04.22 12:13, Dominik Csapak wrote:
> this series improves the behaviour of the file-restore when some mount
> operations take longer than the 30 second pveproxy timeout, and improves
> the startup speed of the restore vm
>
> we do this by moving the disk init into the background of the daemon
> startup, while the hyper server is starting, and by adding a timeout
> option to the file-restore binary.
>
> to be able to report the error back to the gui, we return a
> 'SERVICE_UNAVAILABLE' error in the timeout case, and the gui tries
> again (up to 10 times).
>
> backup patches 2,3 could be applied independently, as they even make
> sense withouth the rest
>
> pve-storage depends on a new pve-common&file-restore
>
> widget-toolkit makes only sense with the other patches, but is
> designed to not change behaviour with the old api
>
> alternatively i could drop the 'json-error' parameter and do it
> always, or when timeout it set.
>
> changes from v1:
> * rebased on master
> * moved the json-error and timeout directly into pve-common (hardcoded)
> since there is only one usage of that function
>
> proxmox-backup:
>
> Dominik Csapak (5):
> restore-daemon: start disk initialization in parallel to the api
> restore-daemon: put blocking code into 'block_in_place'
> restore-daemon: avoid auto-mounting zpools
> file-restore: factor out 'list_files'
> file-restore: add 'timeout' and 'json-error' parameter
>
> proxmox-file-restore/src/main.rs | 206 ++++++++++++------
> proxmox-restore-daemon/src/main.rs | 31 ++-
> .../src/proxmox_restore_daemon/api.rs | 12 +-
> .../src/proxmox_restore_daemon/disk.rs | 20 +-
> 4 files changed, 166 insertions(+), 103 deletions(-)
applied above PBS ones.
fwiw, I'd appreciate getting PBS related patches also on the PBS list, though I somehow
deleted them when I did not find them there ^^.
And just for clarity, there's no need to always CC the full series if it's a pve/pbs
mixed one.
parent reply other threads:[~2022-04-27 17:43 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20220426101401.3216096-1-d.csapak@proxmox.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c6f3e5d-8079-538d-1035-67940df3fffc@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox