From: Filip Schauer <f.schauer@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: Re: [pbs-devel] [PATCH vma-to-pbs 2/4] add support for bulk import of a dump directory
Date: Mon, 14 Oct 2024 12:05:08 +0200 [thread overview]
Message-ID: <197f037c-17f6-454d-a954-902f5d976c9e@proxmox.com> (raw)
In-Reply-To: <1728890686.g12bh8gdiu.astroid@yuna.none>
On 14/10/2024 09:27, Fabian Grünbichler wrote:
>>>> + let mut notes_path_os_string: OsString = path.into();
>>>> + notes_path_os_string.push(".notes");
>>>> + let notes_path: PathBuf = notes_path_os_string.into();
>>> these three lines could become
>>>
>>> let notes_path = path.join(".notes");
>> This does not do the same thing. `.join(".notes")` would add "/.notes"
>> to the path.
> right. filename/with_filename would do the trick then? 🙂
yes, with_file_name does indeed do the trick:
let notes_path = path.with_file_name(format!("{}.notes", file_name));
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-10-14 10:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-24 16:18 [pbs-devel] [PATCH vma-to-pbs 0/4] " Filip Schauer
2024-07-24 16:18 ` [pbs-devel] [PATCH vma-to-pbs 1/4] bump proxmox-sys Filip Schauer
2024-09-04 9:24 ` [pbs-devel] applied: " Fabian Grünbichler
2024-07-24 16:18 ` [pbs-devel] [PATCH vma-to-pbs 2/4] add support for bulk import of a dump directory Filip Schauer
2024-09-04 9:14 ` Fabian Grünbichler
2024-10-08 14:36 ` Filip Schauer
2024-10-14 7:27 ` Fabian Grünbichler
2024-10-14 10:05 ` Filip Schauer [this message]
2024-07-24 16:18 ` [pbs-devel] [PATCH vma-to-pbs 3/4] replace hard coded values with constants Filip Schauer
2024-09-04 9:16 ` Fabian Grünbichler
2024-07-24 16:18 ` [pbs-devel] [PATCH vma-to-pbs 4/4] improve readability of stdout Filip Schauer
2024-09-04 9:18 ` Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=197f037c-17f6-454d-a954-902f5d976c9e@proxmox.com \
--to=f.schauer@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox