* [pbs-devel] [PATCH proxmox-backup] ui: tape: restore: fix default namespace mapping
@ 2023-10-02 7:52 Dominik Csapak
2023-10-02 10:16 ` Mira Limbeck
0 siblings, 1 reply; 3+ messages in thread
From: Dominik Csapak @ 2023-10-02 7:52 UTC (permalink / raw)
To: pbs-devel
the ui shows the default 'root' namespace as target, but this only
worked when no namespace was selected. as soon as one source datastore
had a target namespace selected, the others datastores would be skipped
as there was no namespace mapping for them. To fix that, we simply send
a default namespace mapping for each source datastore without a target
(no target means 'root')
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/tape/window/TapeRestore.js | 2 ++
1 file changed, 2 insertions(+)
diff --git a/www/tape/window/TapeRestore.js b/www/tape/window/TapeRestore.js
index c1d3493c..988ceba2 100644
--- a/www/tape/window/TapeRestore.js
+++ b/www/tape/window/TapeRestore.js
@@ -537,6 +537,8 @@ Ext.define('PBS.TapeManagement.DataStoreMappingGrid', {
let ns = targetns || defaultNs;
if (ns) {
namespaces.push(`store=${source},target=${ns}`);
+ } else {
+ namespaces.push(`store=${source}`);
}
}
});
--
2.30.2
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [pbs-devel] [PATCH proxmox-backup] ui: tape: restore: fix default namespace mapping
2023-10-02 7:52 [pbs-devel] [PATCH proxmox-backup] ui: tape: restore: fix default namespace mapping Dominik Csapak
@ 2023-10-02 10:16 ` Mira Limbeck
2023-10-03 11:20 ` Thomas Lamprecht
0 siblings, 1 reply; 3+ messages in thread
From: Mira Limbeck @ 2023-10-02 10:16 UTC (permalink / raw)
To: pbs-devel
On 10/2/23 09:52, Dominik Csapak wrote:
> the ui shows the default 'root' namespace as target, but this only
> worked when no namespace was selected. as soon as one source datastore
> had a target namespace selected, the others datastores would be skipped
> as there was no namespace mapping for them. To fix that, we simply send
> a default namespace mapping for each source datastore without a target
> (no target means 'root')
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> www/tape/window/TapeRestore.js | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/www/tape/window/TapeRestore.js b/www/tape/window/TapeRestore.js
> index c1d3493c..988ceba2 100644
> --- a/www/tape/window/TapeRestore.js
> +++ b/www/tape/window/TapeRestore.js
> @@ -537,6 +537,8 @@ Ext.define('PBS.TapeManagement.DataStoreMappingGrid', {
> let ns = targetns || defaultNs;
> if (ns) {
> namespaces.push(`store=${source},target=${ns}`);
> + } else {
> + namespaces.push(`store=${source}`);
> }
> }
> });
Worked as expected in my tests. Consider it:
Tested-by: Mira Limbeck <m.limbeck@proxmox.com>
one thing that popped up, unrelated to this patch, it seems the
datastore order in the mapping form changes sometimes.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [pbs-devel] [PATCH proxmox-backup] ui: tape: restore: fix default namespace mapping
2023-10-02 10:16 ` Mira Limbeck
@ 2023-10-03 11:20 ` Thomas Lamprecht
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Lamprecht @ 2023-10-03 11:20 UTC (permalink / raw)
To: Proxmox Backup Server development discussion, Mira Limbeck,
Dominik Csapak
Am 02/10/2023 um 12:16 schrieb Mira Limbeck:
> On 10/2/23 09:52, Dominik Csapak wrote:
>> the ui shows the default 'root' namespace as target, but this only
>> worked when no namespace was selected. as soon as one source datastore
>> had a target namespace selected, the others datastores would be skipped
>> as there was no namespace mapping for them. To fix that, we simply send
>> a default namespace mapping for each source datastore without a target
>> (no target means 'root')
>>
>> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
>> ---
>> www/tape/window/TapeRestore.js | 2 ++
>> 1 file changed, 2 insertions(+)
> Worked as expected in my tests. Consider it:
>
> Tested-by: Mira Limbeck <m.limbeck@proxmox.com>
applied with your T-b tag, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-03 11:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-02 7:52 [pbs-devel] [PATCH proxmox-backup] ui: tape: restore: fix default namespace mapping Dominik Csapak
2023-10-02 10:16 ` Mira Limbeck
2023-10-03 11:20 ` Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox