[pbs-devel] [PATCH proxmox-backup] ui: tape: restore: fix default namespace mapping

[pbs-devel] [PATCH proxmox-backup] ui: tape: restore: fix default namespace mapping

[Dominik Csapak]

the ui shows the default 'root' namespace as target, but this only
worked when no namespace was selected. as soon as one source datastore
had a target namespace selected, the others datastores would be skipped
as there was no namespace mapping for them. To fix that, we simply send
a default namespace mapping for each source datastore without a target
(no target means 'root')

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/tape/window/TapeRestore.js | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/www/tape/window/TapeRestore.js b/www/tape/window/TapeRestore.js
index c1d3493c..988ceba2 100644
--- a/www/tape/window/TapeRestore.js
+++ b/www/tape/window/TapeRestore.js
@@ -537,6 +537,8 @@ Ext.define('PBS.TapeManagement.DataStoreMappingGrid', {
 		let ns = targetns || defaultNs;
 		if (ns) {
 		    namespaces.push(`store=${source},target=${ns}`);
+		} else {
+		    namespaces.push(`store=${source}`);
 		}
 	    }
 	});
-- 
2.30.2

Re: [pbs-devel] [PATCH proxmox-backup] ui: tape: restore: fix default namespace mapping

[Mira Limbeck]

On 10/2/23 09:52, Dominik Csapak wrote:
> the ui shows the default 'root' namespace as target, but this only
> worked when no namespace was selected. as soon as one source datastore
> had a target namespace selected, the others datastores would be skipped
> as there was no namespace mapping for them. To fix that, we simply send
> a default namespace mapping for each source datastore without a target
> (no target means 'root')
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  www/tape/window/TapeRestore.js | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/www/tape/window/TapeRestore.js b/www/tape/window/TapeRestore.js
> index c1d3493c..988ceba2 100644
> --- a/www/tape/window/TapeRestore.js
> +++ b/www/tape/window/TapeRestore.js
> @@ -537,6 +537,8 @@ Ext.define('PBS.TapeManagement.DataStoreMappingGrid', {
>  		let ns = targetns || defaultNs;
>  		if (ns) {
>  		    namespaces.push(`store=${source},target=${ns}`);
> +		} else {
> +		    namespaces.push(`store=${source}`);
>  		}
>  	    }
>  	});

Worked as expected in my tests. Consider it:

Tested-by: Mira Limbeck <m.limbeck@proxmox.com>



one thing that popped up, unrelated to this patch, it seems the
datastore order in the mapping form changes sometimes.

Re: [pbs-devel] [PATCH proxmox-backup] ui: tape: restore: fix default namespace mapping

[Thomas Lamprecht]

Am 02/10/2023 um 12:16 schrieb Mira Limbeck:
> On 10/2/23 09:52, Dominik Csapak wrote:
>> the ui shows the default 'root' namespace as target, but this only
>> worked when no namespace was selected. as soon as one source datastore
>> had a target namespace selected, the others datastores would be skipped
>> as there was no namespace mapping for them. To fix that, we simply send
>> a default namespace mapping for each source datastore without a target
>> (no target means 'root')
>>
>> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
>> ---
>>  www/tape/window/TapeRestore.js | 2 ++
>>  1 file changed, 2 insertions(+)

> Worked as expected in my tests. Consider it:
> 
> Tested-by: Mira Limbeck <m.limbeck@proxmox.com>

applied with your T-b tag, thanks!