From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Mira Limbeck <m.limbeck@proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] ui: tape: restore: fix default namespace mapping
Date: Tue, 3 Oct 2023 13:20:00 +0200 [thread overview]
Message-ID: <18705194-cb67-43c1-8845-9531333716ae@proxmox.com> (raw)
In-Reply-To: <3cdbab95-4aea-5b02-5f40-d4be27ea48a2@proxmox.com>
Am 02/10/2023 um 12:16 schrieb Mira Limbeck:
> On 10/2/23 09:52, Dominik Csapak wrote:
>> the ui shows the default 'root' namespace as target, but this only
>> worked when no namespace was selected. as soon as one source datastore
>> had a target namespace selected, the others datastores would be skipped
>> as there was no namespace mapping for them. To fix that, we simply send
>> a default namespace mapping for each source datastore without a target
>> (no target means 'root')
>>
>> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
>> ---
>> www/tape/window/TapeRestore.js | 2 ++
>> 1 file changed, 2 insertions(+)
> Worked as expected in my tests. Consider it:
>
> Tested-by: Mira Limbeck <m.limbeck@proxmox.com>
applied with your T-b tag, thanks!
prev parent reply other threads:[~2023-10-03 11:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-02 7:52 Dominik Csapak
2023-10-02 10:16 ` Mira Limbeck
2023-10-03 11:20 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18705194-cb67-43c1-8845-9531333716ae@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=m.limbeck@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox