From: Dietmar Maurer <dietmar@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Stefan Reiter <s.reiter@proxmox.com>
Subject: Re: [pbs-devel] [PATCH v2 proxmox-backup 4/5] backup: check all referenced chunks actually exist
Date: Tue, 8 Sep 2020 12:49:26 +0200 (CEST) [thread overview]
Message-ID: <1840686263.957.1599562167285@webmail.proxmox.com> (raw)
In-Reply-To: <20200907153036.9324-5-s.reiter@proxmox.com>
>
> use ::serde::{Serialize};
> use serde_json::{json, Value};
> @@ -73,6 +73,7 @@ struct SharedBackupState {
> dynamic_writers: HashMap<usize, DynamicWriterState>,
> fixed_writers: HashMap<usize, FixedWriterState>,
> known_chunks: HashMap<[u8;32], u32>,
> + touched_chunks: HashSet<[u8;32]>,
> backup_size: u64, // sums up size of all files
> backup_stat: UploadStatistic,
Instead of touched_chunks, can we store that info inside known_chunks?
- known_chunks: HashMap<[u8;32], u32>,
+ known_chunks: HashMap<[u8;32], (u32, bool)>,
next prev parent reply other threads:[~2020-09-08 10:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 15:30 [pbs-devel] [PATCH v2 0/5] Improve corrupt chunk handling Stefan Reiter
2020-09-07 15:30 ` [pbs-devel] [PATCH v2 proxmox-backup 1/5] verify: fix log units Stefan Reiter
2020-09-07 15:30 ` [pbs-devel] [PATCH v2 proxmox-backup 2/5] verify: rename corrupted chunks with .bad extension Stefan Reiter
2020-09-08 10:27 ` Dietmar Maurer
2020-09-07 15:30 ` [pbs-devel] [PATCH v2 proxmox-backup 3/5] gc: remove .bad files on garbage collect Stefan Reiter
2020-09-07 15:30 ` [pbs-devel] [PATCH v2 proxmox-backup 4/5] backup: check all referenced chunks actually exist Stefan Reiter
2020-09-08 10:49 ` Dietmar Maurer [this message]
2020-09-07 15:30 ` [pbs-devel] [PATCH v2 proxmox-backup 5/5] backup: touch all chunks, even if they exist Stefan Reiter
2020-09-08 10:51 ` [pbs-devel] [PATCH v2 0/5] Improve corrupt chunk handling Dietmar Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1840686263.957.1599562167285@webmail.proxmox.com \
--to=dietmar@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=s.reiter@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox