public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Dietmar Maurer <dietmar@proxmox.com>,
	Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [RFC proxmox-backup] add "password hint" to KeyConfig
Date: Wed, 20 Jan 2021 19:20:12 +0100 (CET)	[thread overview]
Message-ID: <1836395635.398.1611166813042@webmail.proxmox.com> (raw)
In-Reply-To: <216794561.395.1611161949649@webmail.proxmox.com>


> Dietmar Maurer <dietmar@proxmox.com> hat am 20.01.2021 17:59 geschrieben:
> 
>  
> > does it make sense to split the "public" (misleading naming ;)) and 
> > private part in tape_encryption_keys.rs? it seems to me that we 
> > access/modify them together, so we might want to make it a single file 
> > to avoid running out of sync? i.e., EncryptionKeyInfo could just get the 
> > KeyConfig as field as well, and we store a list/map of those..
> 
> I have done the split to protect the private part (only accessible by root).
> The public part can be accessed (and even modified (change password) by user backup).

not sure whether that's appropriate - the KeyConfig part is just as well-protected as the user's password choice, so unless there is a reason why this *has* to be accessible by user backup I'd make it root only as well.. anything actually using the key needs to run as root anyhow, so the password change can as well..

there is no public (as in, I don't care who can access this) and private part. there is an unprotected and a semi-protected encoding of the same secret..




      reply	other threads:[~2021-01-20 18:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-19 12:09 Dietmar Maurer
2021-01-20 16:13 ` Fabian Grünbichler
2021-01-20 16:59   ` Dietmar Maurer
2021-01-20 18:20     ` Fabian Grünbichler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1836395635.398.1611166813042@webmail.proxmox.com \
    --to=f.gruenbichler@proxmox.com \
    --cc=dietmar@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal