From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Thomas Lamprecht <t.lamprecht@proxmox.com>,
Maximiliano Sandoval R <m.sandoval@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox 1/2] sys: Use safe wrapper for libc::isatty
Date: Mon, 20 Nov 2023 08:54:22 +0100 (CET) [thread overview]
Message-ID: <1810775013.20.1700466862839@webmail.proxmox.com> (raw)
In-Reply-To: <5e68f9a1-ed8a-4493-9162-b4e285fc2685@proxmox.com>
> Thomas Lamprecht <t.lamprecht@proxmox.com> hat am 19.11.2023 16:09 CET geschrieben:
>
> Am 17/11/2023 um 13:37 schrieb Maximiliano Sandoval R:
> > Use the `std::io::IsTerminal` trait introduced in Rust 1.70.
>
> ack, but a more general question: should we set the msrv in the manifest:
>
> rust-version = "1.70"
>
> We did not bothered to much with that until now, only a bit indirectly through
> increasing the edition to e.g., 2021, and we do not have that many external
> users for it to matter much.
I think that would make sense. most recent debcargo versions (not yet for us) translate this to the corresponding versioned dep, and the error messages are also much nicer and earlier in case somebody tries to build with a too old version..
next prev parent reply other threads:[~2023-11-20 7:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-17 12:37 [pbs-devel] [PATCH proxmox 0/2] Use IsTerminal trait Maximiliano Sandoval R
2023-11-17 12:37 ` [pbs-devel] [PATCH proxmox 1/2] sys: Use safe wrapper for libc::isatty Maximiliano Sandoval R
2023-11-19 15:09 ` Thomas Lamprecht
2023-11-20 7:54 ` Fabian Grünbichler [this message]
2023-11-20 7:55 ` Maximiliano Sandoval
2023-11-17 12:37 ` [pbs-devel] [PATCH proxmox 2/2] router: " Maximiliano Sandoval R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1810775013.20.1700466862839@webmail.proxmox.com \
--to=f.gruenbichler@proxmox.com \
--cc=m.sandoval@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox