From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pbs-devel@lists.proxmox.com, Jakob Klocker <j.klocker@proxmox.com>
Subject: applied: [PATCH proxmox{,-backup} v4 0/5] fix #6990: server: drop verify state on push & pull job
Date: Wed, 11 Nov 2026 23:28:36 +0100 [thread overview]
Message-ID: <179443477829.1246645.8176092495370125037.b4-ty@b4> (raw)
In-Reply-To: <20261015121659.239652-1-j.klocker@proxmox.com>
On Thu, 15 Oct 2026 14:16:54 +0200, Jakob Klocker wrote:
> When syncing a snapshot to another datastore, the source's verify_state
> is currently carried over to the target. This reports the target
> snapshot as verified even though its stored copy was never checked
> there. Since verify jobs skip snapshots that already carry a
> verify_state, the target's copy can't be verified again.
>
> Chunks are checksummed in memory while being transferred, but a verify
> serves a different purpose: confirming the write to the (external)
> target actually succeeded.
>
> [...]
Applied, thanks!
I folded a few changes into patch 4/5, namely:
- the target's own verify state is now also dropped when an archive got
re-synced, as the old result does not cover the rewritten data
- the "nothing changed" fast path compares the manifests ignoring the
verify state, as otherwise a verified source could never match its
stripped target copy again, so every pull re-hashed all archives and
rewrote, and for S3 re-uploaded, the manifest
- the manifest is written through the shared replace_file helper
[proxmox] applied to git/proxmox.git (master)
[1/5] pbs-api-types: implement Hash and Borrow<str> for BackupArchiveName
commit: f00b1061ba7e19f620e1ad1f7b0003b4c46d5097
[proxmox-backup] applied to git/proxmox-backup.git (master)
[2/5] server: pull: run blocking file operations on the blocking pool
commit: b98c63f34d8ccecb78ec8737df9e5b760dc75ff3
[3/5] pbs-datastore: pass expected files to cleanup_unreferenced_files
commit: 908ba15753aedb9822bcfed6e217cb1acc9cd1c2
[4/5] fix #6990: server: drop verify state on non-decrypt pull job
commit: 7241811f7ed6224fa02294053b0953b9453ed417
[5/5] fix #6990: server: drop verify state on push job
commit: bae3060140198d7cdbb3dc37ac08d8356fabf577
prev parent reply other threads:[~2026-11-11 22:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 12:16 [PATCH proxmox{,-backup} v4 0/5] fix #6990: server: drop verify state on push & pull job Jakob Klocker
2026-10-15 12:16 ` [PATCH proxmox v4 1/5] pbs-api-types: implement Hash and Borrow<str> for BackupArchiveName Jakob Klocker
2026-10-15 12:16 ` [PATCH proxmox-backup v4 2/5] server: pull: run blocking file operations on the blocking pool Jakob Klocker
2026-10-15 12:16 ` [PATCH proxmox-backup v4 3/5] pbs-datastore: pass expected files to cleanup_unreferenced_files Jakob Klocker
2026-10-15 12:16 ` [PATCH proxmox-backup v4 4/5] fix #6990: server: drop verify state on non-decrypt pull job Jakob Klocker
2026-10-15 12:16 ` [PATCH proxmox-backup v4 5/5] fix #6990: server: drop verify state on push job Jakob Klocker
2026-11-11 22:28 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179443477829.1246645.8176092495370125037.b4-ty@b4 \
--to=t.lamprecht@proxmox.com \
--cc=j.klocker@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox