From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pbs-devel@lists.proxmox.com, Dominik Csapak <d.csapak@proxmox.com>
Subject: applied: [PATCH proxmox-backup] tape: labeling: improve error message for tapes with existing data
Date: Fri, 2 Oct 2026 14:34:20 +0200 [thread overview]
Message-ID: <179094445764.3221459.14543531759511538211.b4-ty@b4> (raw)
In-Reply-To: <20260928131405.3659144-1-d.csapak@proxmox.com>
On Mon, 28 Sep 2026 15:13:56 +0200, Dominik Csapak wrote:
> A tape used by e.g. tar, has a different block length structure than
> what we expect. When labeling such tape, reading the existing tape
> errors out with 'read failed - unexpected block len' which does not give
> the user any hint what might be wrong if they're not familiar with inner
> workings of our tape code.
>
> Instead, introduce a new error variant in our BlockReadError which we
> can use to return an improved error message, namely the same one when
> the user tries to label an already labeled tape with the hint that it
> has to be formatted first.
>
> [...]
Applied, thanks!
[1/1] tape: labeling: improve error message for tapes with existing data
commit: 13fdd4e73b8d4252b5e53daed12bd360d269f6dd
prev parent reply other threads:[~2026-10-02 12:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 13:13 [PATCH proxmox-backup] tape: labeling: improve error message for tapes with existing data Dominik Csapak
2026-10-02 12:34 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179094445764.3221459.14543531759511538211.b4-ty@b4 \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox