Re: [PATCH proxmox v3 1/3] rest-server: add request logfilter by method and path in h2 service

[Robert Obkircher <r.obkircher@proxmox.com>]

> Allows to optionally filter incoming requests to be excluded from the
> task log. The filter method is provided on instantiation and passes
> the request method and path.
> 
> A first usecase for this is to filter out HTTP level heartbeat
> requests send by the client's backup reader implementation in order
> to avoid log flodding.
> 
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
>
> diff --git a/proxmox-rest-server/src/h2service.rs b/proxmox-rest-server/src/h2service.rs
> index b5edc703..be3797dc 100644
> --- a/proxmox-rest-server/src/h2service.rs
> +++ b/proxmox-rest-server/src/h2service.rs
> @@ -27,15 +27,23 @@ pub struct H2Service<E> {
>      rpcenv: E,
>      worker: Arc<WorkerTask>,
>      debug: bool,
> +    log_filter: Option<fn(&hyper::Method, &str) -> bool>,
If we expect more complex, stateful filters in the future then 
`Option<Arc<dyn Fn>>` would be better.
>  }
>  
>  impl<E: RpcEnvironment + Clone> H2Service<E> {
> -    pub fn new(rpcenv: E, worker: Arc<WorkerTask>, router: &'static Router, debug: bool) -> Self {
> +    pub fn new(
> +        rpcenv: E,
> +        worker: Arc<WorkerTask>,
> +        router: &'static Router,
> +        debug: bool,
> +        log_filter: Option<fn(&hyper::Method, &str) -> bool>,
> +    ) -> Self {
>          Self {
>              rpcenv,
>              worker,
>              router,
>              debug,
> +            log_filter,
>          }
>      }
>  
> @@ -55,7 +63,13 @@ impl<E: RpcEnvironment + Clone> H2Service<E> {
>              Err(err) => return future::err(http_err!(BAD_REQUEST, "{}", err)).boxed(),
>          };
>  
> -        self.debug(format!("{method} {path}"));
> +        if !self
> +            .log_filter
> +            .map(|filter| filter(&method, &path))
> +            .unwrap_or_default()
This confused me initially, because filters are usually associated
with predicates that return true for the elements that should be
kept.

-- 
Robert Obkircher <r.obkircher@proxmox.com>