Re: [PATCH proxmox-backup v4 07/15] pbs-config: drop backup_group helper, use users gid instead

[Robert Obkircher <r.obkircher@proxmox.com>]

> diff --git a/pbs-datastore/src/chunk_store.rs b/pbs-datastore/src/chunk_store.rs
> index a936f5034..09a0242fc 100644
> --- a/pbs-datastore/src/chunk_store.rs
> +++ b/pbs-datastore/src/chunk_store.rs
> @@ -756,12 +756,11 @@ impl ChunkStore {
>              .parent()
>              .ok_or_else(|| format_err!("unable to get chunk dir"))?;
>  
> -        let mut create_options = CreateOptions::new();
> -        if nix::unistd::Uid::effective().is_root() {
> -            let uid = pbs_config::backup_user()?.uid;
> -            let gid = pbs_config::backup_group()?.gid;
> -            create_options = create_options.owner(uid).group(gid);
> -        }
> +        let create_options = if nix::unistd::Uid::effective().is_root() {
> +            proxmox_product_config::default_create_options()
> +        } else {
> +            CreateOptions::new()
> +        };

The previous version never specified a mode in which case apply_to 
seems to default to 0o644.

The new version specifies 0o0640.

This does sound more correct to me, but I wanted to mention it becasue
it does take away some permissions and the modes will now differ for
the two branches.

>          proxmox_sys::fs::replace_file(
>              &chunk_path,
>              raw_data,
> @@ -813,12 +812,11 @@ impl ChunkStore {
>  
>      /// Helper to generate new empty marker file
>      fn create_marker_file(path: &Path) -> Result<(), Error> {
> -        let mut create_options = CreateOptions::new();
> -        if nix::unistd::Uid::effective().is_root() {
> -            let uid = pbs_config::backup_user()?.uid;
> -            let gid = pbs_config::backup_group()?.gid;
> -            create_options = create_options.owner(uid).group(gid);
> -        }
> +        let create_options = if nix::unistd::Uid::effective().is_root() {
> +            proxmox_product_config::default_create_options()
> +        } else {
> +            CreateOptions::new()
> +        };
Same issue here.

-- 
Robert Obkircher <r.obkircher@proxmox.com>