public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Jakob Klocker <j.klocker@proxmox.com>, pbs-devel@lists.proxmox.com
Subject: Re: [RFC proxmox{,-backup} 0/2] fix #7198: count veth uplink for PBS running in an LXC
Date: Wed, 08 Jul 2026 10:45:08 +0200	[thread overview]
Message-ID: <1783500266.gy98vfdd63.astroid@yuna.none> (raw)
In-Reply-To: <56163436-7d4d-4604-bbff-2425e2bf7b2a@proxmox.com>

On July 8, 2026 10:11 am, Jakob Klocker wrote:
> On 7/7/26 2:15 PM, Gabriel Goller wrote:
>> This seems a bit like a band-aid fix to me. Why do we not just get the uplink
>> interface via the default route: e.g. `ip -j route get 1.1.1.1 | jq .[0].dev`?
>> 
> 
> As Fabian mentioned, this wouldn't cover multiple interfaces. If one
> separates backup traffic onto a dedicated interface, that traffic
> wouldn't get picked up.
> 
> IMO the `veth` check is the right call here, at least I haven't found
> a better way. I'm open for suggestions though.

I think the only other (more flexible) solution would be to have a file
listing the interfaces that should be counted..

> What I'm still concerned about is whether it is necessary to handle
> enslaved veth, since they would get picked up. I can't think of a real
> use case where one would want to create such a setup in an LXC, but
> since I'm not that experienced in that topic I'm happy for input!
> 
> Since running a PBS in an LXC is already not that common, paired with
> renaming the interface to a not "normal" name, I would argue that
> handling the enslaved veth is not really necessary.




      reply	other threads:[~2026-07-08  8:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-07 11:20 [RFC proxmox{,-backup} 0/2] fix #7198: count veth uplink for PBS running in an LXC Jakob Klocker
2026-07-07 11:20 ` [PATCH proxmox 1/2] network-api: add is_veth helper to IpLink Jakob Klocker
2026-07-07 11:20 ` [PATCH proxmox-backup 2/2] fix #7198: metric collection: count veth uplink when running in a container Jakob Klocker
2026-07-07 12:14 ` [RFC proxmox{,-backup} 0/2] fix #7198: count veth uplink for PBS running in an LXC Gabriel Goller
2026-07-07 12:47   ` Fabian Grünbichler
2026-07-08  8:49     ` Gabriel Goller
2026-07-08  8:11   ` Jakob Klocker
2026-07-08  8:45     ` Fabian Grünbichler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1783500266.gy98vfdd63.astroid@yuna.none \
    --to=f.gruenbichler@proxmox.com \
    --cc=j.klocker@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal