public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pbs-devel] [PATCH proxmox-backup] fix #2978: allow non-root to view datastore usage
@ 2020-09-03 12:49 Fabian Grünbichler
  2020-09-04  4:19 ` [pbs-devel] applied: " Dietmar Maurer
  0 siblings, 1 reply; 2+ messages in thread
From: Fabian Grünbichler @ 2020-09-03 12:49 UTC (permalink / raw)
  To: pbs-devel

for datastores where the requesting user has read or write permissions,
since the API method itself filters by that already. this is the same
permission setting and filtering that the datastore list API endpoint
does.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---
 src/api2/status.rs | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/api2/status.rs b/src/api2/status.rs
index c44e73f1..10ae8b3d 100644
--- a/src/api2/status.rs
+++ b/src/api2/status.rs
@@ -74,6 +74,9 @@ use crate::config::acl::{
             },
         },
     },
+    access: {
+        permission: &Permission::Anybody,
+    },
 )]
 /// List Datastore usages and estimates
 fn datastore_status(
-- 
2.20.1





^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pbs-devel] applied: [PATCH proxmox-backup] fix #2978: allow non-root to view datastore usage
  2020-09-03 12:49 [pbs-devel] [PATCH proxmox-backup] fix #2978: allow non-root to view datastore usage Fabian Grünbichler
@ 2020-09-04  4:19 ` Dietmar Maurer
  0 siblings, 0 replies; 2+ messages in thread
From: Dietmar Maurer @ 2020-09-04  4:19 UTC (permalink / raw)
  To: Proxmox Backup Server development discussion, Fabian Grünbichler

applied

> On 09/03/2020 2:49 PM Fabian Grünbichler <f.gruenbichler@proxmox.com> wrote:
> 
>  
> for datastores where the requesting user has read or write permissions,
> since the API method itself filters by that already. this is the same
> permission setting and filtering that the datastore list API endpoint
> does.
> 
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
>  src/api2/status.rs | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/src/api2/status.rs b/src/api2/status.rs
> index c44e73f1..10ae8b3d 100644
> --- a/src/api2/status.rs
> +++ b/src/api2/status.rs
> @@ -74,6 +74,9 @@ use crate::config::acl::{
>              },
>          },
>      },
> +    access: {
> +        permission: &Permission::Anybody,
> +    },
>  )]
>  /// List Datastore usages and estimates
>  fn datastore_status(
> -- 
> 2.20.1
> 
> 
> 
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-09-04  4:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-03 12:49 [pbs-devel] [PATCH proxmox-backup] fix #2978: allow non-root to view datastore usage Fabian Grünbichler
2020-09-04  4:19 ` [pbs-devel] applied: " Dietmar Maurer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal