public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pbs-devel@lists.proxmox.com, Christian Ebner <c.ebner@proxmox.com>
Subject: applied: [PATCH proxmox-backup v8 00/17] partially fix #6563: add s3 counter for statistics and notifications
Date: Fri, 10 Apr 2026 02:49:07 +0200	[thread overview]
Message-ID: <177578214248.2697034.10511094955518196902.b4-ty@proxmox.com> (raw)
In-Reply-To: <20260402105333.463088-1-c.ebner@proxmox.com>

On Thu, 02 Apr 2026 12:53:16 +0200, Christian Ebner wrote:
> This patch series implements request and traffic counters for the s3
> client, being shared as atomic counters via shared memory and mmapping
> across all s3-client instances.
> 
> The shared counters are instantiated on demand for individual
> datastores with s3 backend on s3 client instantiation and stored as
> part of the datastore implementation by loading the mmapped file on
> datastore creation, being cached for further access. Counter threshold
> values can be defined in the datastore options, allowing to send
> notifications via the notification system if counters exceeded the set
> threshold values. Further, a per-datastore schedule can be configured
> to reset the counters with given interval.
> 
> [...]

Applied, with a few follow-ups that should address your own and Dominik
findings, thanks!

[01/17] api: s3: add endpoint to reset s3 request counters
        commit: b1ad47ff8c70cd37cd6a47760c19c938fb857fe1
[02/17] bin: s3: expose request counter reset method as cli command
        commit: aa25261a4404987759ae394cd860431a1f33da98
[03/17] ui: datastore summary: move store to be part of summary panel
        commit: d65adbdb193fb817f2c3ee50dc0a7e5c44a00659
[04/17] ui: expose s3 request counter statistics in the datastore summary
        commit: 3e65758d43c3a04b4aeed20631c5f697edd777a4
[05/17] metrics: collect s3 datastore statistics as rrd metrics
        commit: f07cce815fd5c8be1ded15bde6cdeae1a21d8234
[06/17] api: admin: expose s3 statistics in datastore rrd data
        commit: 2dc9be41a9d03b20813ed2b670e5253ef091279d
[07/17] partially fix #6563: ui: expose s3 rrd charts in datastore summary
        commit: c0cfbd08de6d07e9b64211f3684f7e7ff763982c
[08/17] datastore: refactor datastore lookup parameters into dedicated type
        commit: e426e2f090d0bd2ab3cba3939e1218f71b8e83a1
[09/17] api: config: update notification thresholds for config and counters
        commit: d508cbc2b8c86eb37a40df48383f06750985c6f9
[10/17] ui: add notification thresholds edit window
        commit: 8b8876fcabf4a8f61076186aa20d587c8cb08dc1
[11/17] notification: define templates and template data for thresholds
        commit: 261b83d9631e68c68e1b5a5a9af158ee15d5f2c9
[12/17] datastore: add thresholds notification callback on datastore lookup
        commit: d63b825979f5d28879cefb99ab1026913319c8eb
[13/17] api/ui: notifications: add 'thresholds' as notification type value
        commit: 3f843d2698fbf0f6f4f99b0d72d9c79732e9236d
[14/17] api: config: allow counter reset schedule editing
        commit: a5ddd2b968901fe2aecf1dd2d206a9a37339a757
[15/17] ui: expose counter reset schedule edit window
        commit: 6696c779ae6a3daccab338ced6d780cedbbf35d1
[16/17] bin: proxy: periodically schedule counter reset task
        commit: 3f6d96fd547dbc9beaa6656b5e611ff316ae9aa7
[17/17] ui: add task description for scheduled counter reset
        commit: 0c25deb1bdf14de989c9f96ea5b1f56ad366cdb8




      parent reply	other threads:[~2026-04-10  0:49 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-02 10:53 Christian Ebner
2026-04-02 10:53 ` [PATCH proxmox-backup v8 01/17] api: s3: add endpoint to reset s3 request counters Christian Ebner
2026-04-02 10:53 ` [PATCH proxmox-backup v8 02/17] bin: s3: expose request counter reset method as cli command Christian Ebner
2026-04-02 10:53 ` [PATCH proxmox-backup v8 03/17] ui: datastore summary: move store to be part of summary panel Christian Ebner
2026-04-02 10:53 ` [PATCH proxmox-backup v8 04/17] ui: expose s3 request counter statistics in the datastore summary Christian Ebner
2026-04-09  8:21   ` Dominik Csapak
2026-04-09  8:28     ` Christian Ebner
2026-04-02 10:53 ` [PATCH proxmox-backup v8 05/17] metrics: collect s3 datastore statistics as rrd metrics Christian Ebner
2026-04-02 10:53 ` [PATCH proxmox-backup v8 06/17] api: admin: expose s3 statistics in datastore rrd data Christian Ebner
2026-04-02 10:53 ` [PATCH proxmox-backup v8 07/17] partially fix #6563: ui: expose s3 rrd charts in datastore summary Christian Ebner
2026-04-02 10:53 ` [PATCH proxmox-backup v8 08/17] datastore: refactor datastore lookup parameters into dedicated type Christian Ebner
2026-04-02 10:53 ` [PATCH proxmox-backup v8 09/17] api: config: update notification thresholds for config and counters Christian Ebner
2026-04-02 10:53 ` [PATCH proxmox-backup v8 10/17] ui: add notification thresholds edit window Christian Ebner
2026-04-02 10:53 ` [PATCH proxmox-backup v8 11/17] notification: define templates and template data for thresholds Christian Ebner
2026-04-02 10:53 ` [PATCH proxmox-backup v8 12/17] datastore: add thresholds notification callback on datastore lookup Christian Ebner
2026-04-02 10:53 ` [PATCH proxmox-backup v8 13/17] api/ui: notifications: add 'thresholds' as notification type value Christian Ebner
2026-04-02 10:53 ` [PATCH proxmox-backup v8 14/17] api: config: allow counter reset schedule editing Christian Ebner
2026-04-02 10:53 ` [PATCH proxmox-backup v8 15/17] ui: expose counter reset schedule edit window Christian Ebner
2026-04-02 10:53 ` [PATCH proxmox-backup v8 16/17] bin: proxy: periodically schedule counter reset task Christian Ebner
2026-04-02 10:53 ` [PATCH proxmox-backup v8 17/17] ui: add task description for scheduled counter reset Christian Ebner
2026-04-09  9:34 ` [PATCH proxmox-backup v8 00/17] partially fix #6563: add s3 counter for statistics and notifications Dominik Csapak
2026-04-09  9:39   ` Christian Ebner
2026-04-10  0:49 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=177578214248.2697034.10511094955518196902.b4-ty@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal