From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pbs-devel@lists.proxmox.com, Christian Ebner <c.ebner@proxmox.com>
Subject: applied: [PATCH proxmox{,-backup} v4 0/8] fix #6716: Add support for http proxy configuration for S3 endpoints
Date: Sun, 5 Apr 2026 11:09:08 +0200 [thread overview]
Message-ID: <177538014549.2644371.18338634086076668705.b4-ty@proxmox.com> (raw)
In-Reply-To: <20260327121319.628881-1-c.ebner@proxmox.com>
On Fri, 27 Mar 2026 13:13:11 +0100, Christian Ebner wrote:
> This patch series exposes the nodes proxy config setting to the S3
> clients for datastores backed by an S3 object store.
>
> To honor crate boundaries, the proxy configuration is refactored to
> be part of pbs-config instead of proxmox-backup. The API types are
> move to pbs-api-types, inlining proxmox_backup::tools::config::from_property_string()
> and NodeConfig::validate() to do so without creating additional unwanted
> dependencies. The schema definition for the proxy is moved to proxmox-http
> instead, already containing the proxy config definition.
>
> [...]
Applied, with the trivial context merge conflict from the S3 counter series
resolved, thanks!
btw. I fixed up the s/call side/call site/ typo that was present in three
commit messages.
[1/6] pbs-config: use http proxy schema moved to proxmox-http crate
commit: 9759277cc6cd6d0c8fc28aecced4f6ccdefe34d9
[2/6] config: inline NodeConfig::validate() to its only call side
commit: 28f6a7134d9eb2bec8495407aa7d69f8d194c2f6
[3/6] config: use moved NodeConfig definitions in pbs-api-types
commit: 6279216832c6c3a520e656f3641d141b247c5561
[4/6] tools: drop unused from_property_string() helper
commit: ff149a6a3faf78e61d057e9dcaa3f3d5966cbae7
[5/6] config: move node config into pbs-config, including helper tools
commit: 6a6bd6143dfe7014ab5dc2dc3aae4bee32098df6
[6/6] fix #6716: pass node http proxy config to s3 backend
commit: fbf8d1b250113e8c754aeae807fe3c78a95c3101
prev parent reply other threads:[~2026-04-05 9:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-27 12:13 Christian Ebner
2026-03-27 12:13 ` [PATCH proxmox v4 1/8] http: move http proxy schema from PBS to crate's api types Christian Ebner
2026-03-27 12:13 ` [PATCH proxmox v4 2/8] pbs-api-types: move over NodeConfig and related api type from PBS Christian Ebner
2026-03-31 11:17 ` Hannes Laimer
2026-03-27 12:13 ` [PATCH proxmox-backup v4 3/8] pbs-config: use http proxy schema moved to proxmox-http crate Christian Ebner
2026-03-27 12:13 ` [PATCH proxmox-backup v4 4/8] config: inline NodeConfig::validate() to its only call side Christian Ebner
2026-03-27 12:13 ` [PATCH proxmox-backup v4 5/8] config: use moved NodeConfig definitions in pbs-api-types Christian Ebner
2026-03-27 12:13 ` [PATCH proxmox-backup v4 6/8] tools: drop unused from_property_string() helper Christian Ebner
2026-03-27 12:13 ` [PATCH proxmox-backup v4 7/8] config: move node config into pbs-config, including helper tools Christian Ebner
2026-03-27 12:13 ` [PATCH proxmox-backup v4 8/8] fix #6716: pass node http proxy config to s3 backend Christian Ebner
2026-03-31 11:18 ` [PATCH proxmox{,-backup} v4 0/8] fix #6716: Add support for http proxy configuration for S3 endpoints Hannes Laimer
2026-03-31 21:30 ` partially-applied: " Thomas Lamprecht
2026-04-05 9:09 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177538014549.2644371.18338634086076668705.b4-ty@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox