Re: [PATCH proxmox-backup v3 5/6] config: move node config into pbs-config, including helper tools

["Fabian Grünbichler" <f.gruenbichler@proxmox.com>]

On March 12, 2026 12:42 pm, Christian Ebner wrote:
> None of the helpers are required in proxmox-backup anymore, all
> encapsulated in the pbs-config crate. Keep however the same
> `tools::config` module layout.
> 
> Adapt all callsides to use pbs_config::node to interact with the node
> config.
> 
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
>  pbs-config/Cargo.toml                   | 1 +
>  pbs-config/src/lib.rs                   | 2 ++
>  {src/config => pbs-config/src}/node.rs  | 7 ++++---
>  {src => pbs-config/src}/tools/config.rs | 0
>  pbs-config/src/tools/mod.rs             | 1 +
>  src/api2/config/remote.rs               | 2 +-
>  src/api2/node/apt.rs                    | 2 +-
>  src/api2/node/certificates.rs           | 4 ++--
>  src/api2/node/config.rs                 | 8 ++++----
>  src/api2/node/subscription.rs           | 2 +-
>  src/bin/proxmox-backup-proxy.rs         | 9 ++++-----
>  src/bin/proxmox-daily-update.rs         | 2 +-
>  src/config/mod.rs                       | 1 -
>  src/tools/mod.rs                        | 1 -
>  14 files changed, 22 insertions(+), 20 deletions(-)
>  rename {src/config => pbs-config/src}/node.rs (89%)


>  rename {src => pbs-config/src}/tools/config.rs (100%)
>  create mode 100644 pbs-config/src/tools/mod.rs

nit: I think this doesn't make a lot of sense,
(pbs-config/)tools/config.rs should probably be renamed to something
like pbs-config/key_value.rs or pbs-config/simple.rs ? or even be
inlined into node.rs, if we don't expect more such config files to be
introduced..