public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: pbs-devel@lists.proxmox.com, Robert Obkircher <r.obkircher@proxmox.com>
Subject: applied-series: [PATCH v6 proxmox-backup 00/18] fix: #3847 pipe from STDIN to proxmox-backup-client
Date: Fri,  6 Mar 2026 13:26:27 +0100	[thread overview]
Message-ID: <177279998308.622772.3760251337159624003.b4-ty@proxmox.com> (raw)
In-Reply-To: <20260210150642.469670-1-r.obkircher@proxmox.com>


On Tue, 10 Feb 2026 16:06:16 +0100, Robert Obkircher wrote:
> Add support for commands like:
>     ssh host cmd | proxmox-backup-client backup data.img:/dev/stdin
>     proxmox-backup-client backup a.img:<(mysqldump) b.img:<(pgdump)
> 
> Changes since v5:
> 
> Client:
> - add IndexType::to_prefix_and_size helper and fix format string nit
> - drop support for '-' but log helpful warnings
> - fail early for duplicate pipes
> - avoid calling poll_next on terminated streams
> 
> [...]

Applied, thanks!

[01/18] datastore: remove Arc<ChunkStore> from FixedIndexWriter
        commit: 9fa339888acf8e5c882694c3a618751ade627012
[02/18] datastore: remove Arc<ChunkStore> from DynamicIndexWriter
        commit: 7759671aac4e78e8c30640ad3860ed74c28e66d2
[03/18] datastore: add TempDir that is automatically deleted on drop
        commit: 79d029e0199c223b75755a5e989a2d1d5ab6fd82
[04/18] datastore: use temporary directory for chunk store test
        commit: 1ab0b385377c972fb8ac072537e615f5b3f55030
[05/18] datastore: combine public FixedIndexWriter methods into add_chunk
        commit: 2ff0471f04138b05fd02dd25c3b2800ef2dd9110
[06/18] datastore: use fixed size types for FixedIndexWriter
        commit: 1aa2814c81c006a3116faa7195657b16ed84f132
[07/18] datastore: verify that chunk_size is a power of two
        commit: f7f94b157f432ff00209d5f48d7b66ee483744b5
[08/18] datastore: support writing fidx files of unknown size
        commit: af28de916b6c5660ef74904ddda484bcec912391
[09/18] datastore: test FixedIndexWriter
        commit: a2785041db7360f40543ddc626392c78c3c10215
[10/18] api: backup: make fixed index file size optional
        commit: 28fb8143bb85d3cfe3430040259283c413f6495a
[11/18] api: verify fixed index writer size on close
        commit: 760f40de97f0dc985ff3ef7e58b13e27ea9d041a
[12/18] client: don't poll terminated source in FixedChunkStream
        commit: 1860450a6ee1bc61835f7e498772784c09414a33
[13/18] client: don't poll terminated source in ChunkStream
        commit: cacb4e8ecca240a715de5ea1c62235f5685b57fd
[14/18] fix #3847: client: support fifo pipe inputs for image backups
        commit: 2db23ce830670c184f982e1d9e8f4cc9053fa8af
[15/18] client: Fail early if the same pipe is specified for multiple inputs
        commit: 6596442b1282930abaf9e9795450ad4692513e51
[16/18] datastore: compute fidx file size with overflow checks
        commit: b9d60cd6a2cbca17a7a3c559bae8d4741f67fe66
[17/18] datastore: support writing fidx files on systems with larger page size
        commit: 0b99efee4f4436cca88a02651c3f7c6413a27e34
[18/18] datastore: support incremental fidx uploads with different size
        commit: 433508f4bc170d6814f68f1f3f8af6c8634b4624

added a few follow-ups after off-list discussion:
- use tempfile::TempDir for tests instead of custom implementation
- replace a few should-not-happen panics with errors

Best regards,
-- 
Fabian Grünbichler <f.gruenbichler@proxmox.com>




      parent reply	other threads:[~2026-03-06 12:26 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-10 15:06 Robert Obkircher
2026-02-10 15:06 ` [PATCH v6 proxmox-backup 01/18] datastore: remove Arc<ChunkStore> from FixedIndexWriter Robert Obkircher
2026-02-10 15:06 ` [PATCH v6 proxmox-backup 02/18] datastore: remove Arc<ChunkStore> from DynamicIndexWriter Robert Obkircher
2026-02-10 15:06 ` [PATCH v6 proxmox-backup 03/18] datastore: add TempDir that is automatically deleted on drop Robert Obkircher
2026-02-10 15:06 ` [PATCH v6 proxmox-backup 04/18] datastore: use temporary directory for chunk store test Robert Obkircher
2026-02-10 15:06 ` [PATCH v6 proxmox-backup 05/18] datastore: combine public FixedIndexWriter methods into add_chunk Robert Obkircher
2026-02-10 15:06 ` [PATCH v6 proxmox-backup 06/18] datastore: use fixed size types for FixedIndexWriter Robert Obkircher
2026-02-10 15:06 ` [PATCH v6 proxmox-backup 07/18] datastore: verify that chunk_size is a power of two Robert Obkircher
2026-02-17  9:13   ` Robert Obkircher
2026-02-17  9:40     ` Christian Ebner
2026-02-10 15:06 ` [PATCH v6 proxmox-backup 08/18] datastore: support writing fidx files of unknown size Robert Obkircher
2026-02-10 15:06 ` [PATCH v6 proxmox-backup 09/18] datastore: test FixedIndexWriter Robert Obkircher
2026-02-10 15:06 ` [PATCH v6 proxmox-backup 10/18] api: backup: make fixed index file size optional Robert Obkircher
2026-02-10 15:06 ` [PATCH v6 proxmox-backup 11/18] api: verify fixed index writer size on close Robert Obkircher
2026-02-10 15:06 ` [PATCH v6 proxmox-backup 12/18] client: don't poll terminated source in FixedChunkStream Robert Obkircher
2026-02-17 10:01   ` Christian Ebner
2026-02-17 10:06     ` Christian Ebner
2026-02-10 15:06 ` [PATCH v6 proxmox-backup 13/18] client: don't poll terminated source in ChunkStream Robert Obkircher
2026-02-10 15:06 ` [PATCH v6 proxmox-backup 14/18] fix #3847: client: support fifo pipe inputs for image backups Robert Obkircher
2026-02-10 15:06 ` [PATCH v6 proxmox-backup 15/18] client: Fail early if the same pipe is specified for multiple inputs Robert Obkircher
2026-02-10 15:06 ` [PATCH v6 proxmox-backup 16/18] datastore: compute fidx file size with overflow checks Robert Obkircher
2026-02-10 15:06 ` [PATCH v6 proxmox-backup 17/18] datastore: support writing fidx files on systems with larger page size Robert Obkircher
2026-02-10 15:06 ` [PATCH v6 proxmox-backup 18/18] datastore: support incremental fidx uploads with different size Robert Obkircher
2026-02-17 12:42 ` [PATCH v6 proxmox-backup 00/18] fix: #3847 pipe from STDIN to proxmox-backup-client Christian Ebner
2026-03-06 12:26 ` Fabian Grünbichler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=177279998308.622772.3760251337159624003.b4-ty@proxmox.com \
    --to=f.gruenbichler@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    --cc=r.obkircher@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal