public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: pbs-devel@lists.proxmox.com, Robert Obkircher <r.obkircher@proxmox.com>
Subject: partially-applied: [PATCH v1 proxmox-backup 00/11] fix various warnings
Date: Thu,  5 Mar 2026 12:20:49 +0100	[thread overview]
Message-ID: <177270964629.616099.10364687966170936138.b4-ty@proxmox.com> (raw)
In-Reply-To: <20260226144033.211039-1-r.obkircher@proxmox.com>


On Thu, 26 Feb 2026 15:40:14 +0100, Robert Obkircher wrote:
> The first 10 patches fix all clippy warnings expect the one about
> future incompatibilities in the num-bigint-dig v0.8.4 depencency.
> 
> The last patch is an attempt at fixing the compiler warnings about the
> deprecated flock function, but I'm not sure if this is an acceptable
> solution.
> 
> [...]

Applied all except 6 and 11, thanks!

[01/11] datastore: remove allow(clippy::cast_ptr_alignment) attribute
        commit: bfcfadd945b09790d61a7488f46e4f0cd6a0ef28
[02/11] api: use checked_div for compression ratio calculation
        commit: db2e38a7829a6e05848d8e42ea74a65932dc647b
[03/11] datastore+server: sort by key instead of using comparison functions
        commit: a4170cddbafd78598b3ca9527e7780c1f77826f6
[04/11] api: remove unnecessary ampersand to fix clippy warning
        commit: 25aab8374e6ed11ba46ed23d51e8487a021e8403
[05/11] bin: debug: use pattern match instead of is_some+unwrap
        commit: a46daf70d48a6d5084ab6ae8c8d6de985ceb9266

[06/11] bin: proxy: fix clippy warning about unnecesary use of find_map

opted to instead allow the lint and add a TODO comment, less churn and easier
to read that way IMHO

[07/11] datastore: silence warning about too many arguments
        commit: ac2135f74a30c7299712d59471877015034be37e
[08/11] client: catalog shell: avoid unnecessary block_on in async code
        commit: 6bdd577755c45681c5c561f7b95796ea1b3decba
[09/11] client: catalog shell: combine multiple block_on calls into one
        commit: 3b017ac5ca4867b40db1c5950795936546a67ec1
[10/11] client: catalog shell: avoid unsafe transmute
        commit: acf2bb0f8bf9bcef21344833466fa96445a538a7

[11/11] tape: media catalog: use Flock wrapper instead of deprecated function
        (no commit info)

replied to that one individually!

Best regards,
-- 
Fabian Grünbichler <f.gruenbichler@proxmox.com>




      parent reply	other threads:[~2026-03-05 11:21 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-26 14:40 Robert Obkircher
2026-02-26 14:40 ` [PATCH v1 proxmox-backup 01/11] datastore: remove allow(clippy::cast_ptr_alignment) attribute Robert Obkircher
2026-02-26 14:40 ` [PATCH v1 proxmox-backup 02/11] api: use checked_div for compression ratio calculation Robert Obkircher
2026-02-26 14:40 ` [PATCH v1 proxmox-backup 03/11] datastore+server: sort by key instead of using comparison functions Robert Obkircher
2026-02-26 14:40 ` [PATCH v1 proxmox-backup 04/11] api: remove unnecessary ampersand to fix clippy warning Robert Obkircher
2026-02-26 14:40 ` [PATCH v1 proxmox-backup 05/11] bin: debug: use pattern match instead of is_some+unwrap Robert Obkircher
2026-02-26 14:40 ` [PATCH v1 proxmox-backup 06/11] bin: proxy: fix clippy warning about unnecesary use of find_map Robert Obkircher
2026-02-26 14:40 ` [PATCH v1 proxmox-backup 07/11] datastore: silence warning about too many arguments Robert Obkircher
2026-02-26 14:40 ` [PATCH v1 proxmox-backup 08/11] client: catalog shell: avoid unnecessary block_on in async code Robert Obkircher
2026-02-26 14:40 ` [PATCH v1 proxmox-backup 09/11] client: catalog shell: combine multiple block_on calls into one Robert Obkircher
2026-02-26 14:40 ` [PATCH v1 proxmox-backup 10/11] client: catalog shell: avoid unsafe transmute Robert Obkircher
2026-02-26 14:40 ` [PATCH v1 proxmox-backup 11/11] tape: media catalog: use Flock wrapper instead of deprecated function Robert Obkircher
2026-03-05 11:08   ` Fabian Grünbichler
2026-03-05 13:13     ` Dominik Csapak
2026-03-05 14:39       ` Robert Obkircher
2026-03-05 11:20 ` Fabian Grünbichler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=177270964629.616099.10364687966170936138.b4-ty@proxmox.com \
    --to=f.gruenbichler@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    --cc=r.obkircher@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal