From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: pbs-devel@lists.proxmox.com, Christian Ebner <c.ebner@proxmox.com>
Subject: applied: [PATCH proxmox-backup] chunk store: s3: mute warning on overwrite empty chunk in local cache
Date: Thu, 5 Mar 2026 09:50:42 +0100 [thread overview]
Message-ID: <177270064027.249592.16258482045291452957.b4-ty@proxmox.com> (raw)
In-Reply-To: <20260304103600.263896-1-c.ebner@proxmox.com>
On Wed, 04 Mar 2026 11:36:00 +0100, Christian Ebner wrote:
> For regular datastores overwriting chunks which have 0 size is
> unexpected and cannot happen under regular operation. For datastores
> backed by an S3 object storage, this is however expected as regular
> operation if the cache reaches its capacity, since chunks get evicted
> from the cache by leaving an empty file as chunk marker behind.
>
> While the warning is benign, it causes false alerts in the task logs.
> Therefore, silence the warning if the chunk insert overwriting the
> file happens via the local datastore cache.
>
> [...]
Applied, thanks!
Might be something to consider when refactoring the whole datastore/chunkstore
interaction with a proper locked wrapper and integrating the backend - this
could then be derived from the backend?
[1/1] chunk store: s3: mute warning on overwrite empty chunk in local cache
commit: fa9fa9b82d768b912987f78df313cea6fd145078
Best regards,
--
Fabian Grünbichler <f.gruenbichler@proxmox.com>
next prev parent reply other threads:[~2026-03-05 8:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-04 10:36 Christian Ebner
2026-03-05 8:50 ` Fabian Grünbichler [this message]
2026-03-05 9:22 ` applied: " Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177270064027.249592.16258482045291452957.b4-ty@proxmox.com \
--to=f.gruenbichler@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox