public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pbs-devel@lists.proxmox.com,
	Maximiliano Sandoval <m.sandoval@proxmox.com>
Subject: applied: [pbs-devel] [PATCH proxmox] lang: Remove offsetof macro
Date: Tue, 10 Feb 2026 10:26:20 +0100	[thread overview]
Message-ID: <177071557651.2615881.2701665102943222231.b4-ty@proxmox.com> (raw)
In-Reply-To: <20260126141215.401447-1-m.sandoval@proxmox.com>

On Mon, 26 Jan 2026 15:12:11 +0100, Maximiliano Sandoval wrote:
> With rust 1.90 this will crash while running cargo test with
> 
> $ RUST_BACKTRACE=1 cargo test
> 
> null pointer dereference occurred
> stack backtrace:
>    0: __rustc::rust_begin_unwind
>              at /usr/src/rustc-1.90.0/library/std/src/panicking.rs:697:5
>    1: core::panicking::panic_nounwind_fmt::runtime
>              at /usr/src/rustc-1.90.0/library/core/src/panicking.rs:117:22
>    2: core::panicking::panic_nounwind_fmt
>              at /usr/src/rustc-1.90.0/library/core/src/intrinsics/mod.rs:2367:9
>    3: core::panicking::panic_null_pointer_dereference
>              at /usr/src/rustc-1.90.0/library/core/src/panicking.rs:311:5
>    4: rust_out::main::_doctest_main_proxmox_lang_src_lib_rs_71_0
>    5: rust_out::main
>    6: core::ops::function::FnOnce::call_once
> 
> [...]

Applied, thanks!
Note that I rewrote the commit message completely, as having a full ordinary
rust backtrace with 90% being just the standard panic and unwind frame pointers
is really not providing anything useful, OTOH., knowing that there is a
built-in offset_of macro since rust 1.77, that there is no usage of our macro
in our code anymore, and having some references to this lint changing from a
warning to an error provides context and background that is good to know.

[1/1] lang: Remove offsetof macro
      commit: 2c70b4c98a6f6c86755f97bae109bacd3c3b1703




      parent reply	other threads:[~2026-02-10  9:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-26 14:12 Maximiliano Sandoval
2026-01-30  8:15 ` Christian Ebner
2026-02-10  9:26 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=177071557651.2615881.2701665102943222231.b4-ty@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=m.sandoval@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal