Re: [pbs-devel] [PATCH proxmox-backup v5 3/5] acme: drop local AcmeClient

["Fabian Grünbichler" <f.gruenbichler@proxmox.com>]

On January 14, 2026 9:56 am, Samuel Rufinatscha wrote:
> On 1/13/26 2:44 PM, Fabian Grünbichler wrote:
>> On January 8, 2026 12:26 pm, Samuel Rufinatscha wrote:
>>> PBS currently uses its own ACME client and API logic, while PDM uses the
>>> factored out proxmox-acme and proxmox-acme-api crates. This duplication
>>> risks differences in behaviour and requires ACME maintenance in two
>>> places. This patch is part of a series to move PBS over to the shared
>>> ACME stack.
>>>
>>> Changes:
>>> - Remove the local src/acme/client.rs and switch to
>>> proxmox_acme::async_client::AcmeClient where needed.
>>> - Use proxmox_acme_api::load_client_with_account to the custom
>>> AcmeClient::load() function
>>> - Replace the local do_register() logic with
>>> proxmox_acme_api::register_account, to further ensure accounts are persisted
>>> - Replace the local AcmeAccountName type, required for
>>> proxmox_acme_api::register_account
>>>
>>> Signed-off-by: Samuel Rufinatscha <s.rufinatscha@proxmox.com>
>>> ---
>>>   src/acme/client.rs                     | 691 -------------------------
>>>   src/acme/mod.rs                        |   3 -
>>>   src/acme/plugin.rs                     |   2 +-
>>>   src/api2/config/acme.rs                |  50 +-
>>>   src/api2/node/certificates.rs          |   2 +-
>>>   src/api2/types/acme.rs                 |   8 -
>>>   src/bin/proxmox_backup_manager/acme.rs |  17 +-
>>>   src/config/acme/mod.rs                 |   8 +-
>>>   src/config/node.rs                     |   9 +-
>>>   9 files changed, 36 insertions(+), 754 deletions(-)
>>>   delete mode 100644 src/acme/client.rs
>>>
>> 
>> [..]
>> 
>>> diff --git a/src/config/acme/mod.rs b/src/config/acme/mod.rs
>>> index ac89ae5e..e4639c53 100644
>>> --- a/src/config/acme/mod.rs
>>> +++ b/src/config/acme/mod.rs
>> 
>> I think this whole file should probably be replaced entirely by
>> proxmox-acme-api , which - AFAICT - would just require adding the
>> completion helpers there?
>>
> 
> Good point, yes I think moving the completion helpers would
> allow us to get rid of this file. PDM does not make use of
> them / there is atm no 1:1 code in proxmox/ for these helpers.

only because https://bugzilla.proxmox.com/show_bug.cgi?id=7179 is not
yet implemented ;) so please coordinate with Shan to avoid doing the
work twice.


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel