Re: [pbs-devel] [PATCH proxmox-backup v2 0/8] followups for garbage collection

["Fabian Grünbichler" <f.gruenbichler@proxmox.com>]

On December 11, 2025 4:38 pm, Christian Ebner wrote:
> This patch series contains some followup to the recently introduced
> changes to phase 2 of garbage collection on s3 backed datastores [0]
> and clenups for marker files during phase 3 [1], as well as some
> refactoring of the chunk filename extension parsing and bad chunk
> filename generation.
> 
> The first patch introduces a dedicated struct for tracking objects
> to be deleted from the s3 object store during phase 2, bundling the
> length and age based deletion threshold logic to the list state.
> 
> Subsequent patches rename and adapt the chunk store iterator to
> optimize for regular chunk filenames and clearly distinguish chunks
> by directory entry filename extension.
> 
> Further, chunk extension parsing and bad chunk filename generation are
> moved to be associated functions of the newly introduced `ChunkExt`
> enum.
> 
> Changes since version 1 (thanks @Fabian for comments):
> - Rebased onto current master
> - Followup patches for refactoring extension parsing and bad chunk
>   filename generation.

a few more nits inline, but in general this already looks like a nice
cleanup!

> 
> [0] https://lore.proxmox.com/pbs-devel/2b637884-f6bd-434d-be00-fa4e9d9e2dcb@proxmox.com/T/
> [1] https://lore.proxmox.com/pbs-devel/1764145262.ycdoq9dzrx.astroid@yuna.none/T/
> 
> proxmox-backup:
> 
> Christian Ebner (8):
>   GC: Move S3 delete list state and logic to a dedicated struct
>   chunk store: rename and limit scope for chunk store iterator
>   chunk store: invert chunk filename checks in chunk store iterator
>   chunk store: return chunk extension and check for used marker
>   chunk store: refactor chunk extension parsing into dedicated helper
>   datastore: move bad chunk touching logic to chunk store
>   chunk store: move next bad chunk path generator into dedicated helper
>   chunk store: move bad chunk filename generation into dedicated helper
> 
>  pbs-datastore/src/chunk_store.rs | 100 ++++++++++++++++----
>  pbs-datastore/src/datastore.rs   | 154 +++++++++++++++----------------
>  2 files changed, 161 insertions(+), 93 deletions(-)
> 
> 
> Summary over all repositories:
>   2 files changed, 161 insertions(+), 93 deletions(-)
> 
> -- 
> Generated by git-murpp 0.8.1
> 
> 
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
> 
> 
> 


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel