From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Christian Ebner <c.ebner@proxmox.com>, pbs-devel@lists.proxmox.com
Subject: Re: [pbs-devel] [PATCH proxmox-backup 0/4] followups for garbage collection
Date: Wed, 10 Dec 2025 15:18:37 +0100 [thread overview]
Message-ID: <176537631743.371273.12867159169043875156@yuna.proxmox.com> (raw)
In-Reply-To: <20251126133419.570874-1-c.ebner@proxmox.com>
could you rebase this? patch #1 doesn't apply anymore..
Quoting Christian Ebner (2025-11-26 14:34:15)
> This patch series contains some followup to the recently introduced
> changes to phase 2 of garbage collection on s3 backed datastores [0]
> and clenups for marker files during phase 3 [1].
>
> The first patch introduces a dedicated struct for tracking objects
> to be deleted from the s3 object store during phase 2, bundling the
> length and age based deletion threshold logic to the list state.
>
> Subsequent patches rename and adapt the chunk store iterator to
> optimize for regular chunk filenames and clearly distinguish chunks
> by directory entry filename extension.
>
> [0] https://lore.proxmox.com/pbs-devel/2b637884-f6bd-434d-be00-fa4e9d9e2dcb@proxmox.com/T/
> [1] https://lore.proxmox.com/pbs-devel/1764145262.ycdoq9dzrx.astroid@yuna.none/T/
>
> proxmox-backup:
>
> Christian Ebner (4):
> GC: Move S3 delete list state and logic to a dedicated struct
> chunk store: rename and limit scope for chunk store iterator
> chunk store: invert chunk filename checks in chunk store iterator
> chunk store: return chunk extension and check for used marker
>
> pbs-datastore/src/chunk_store.rs | 61 ++++++++++----
> pbs-datastore/src/datastore.rs | 132 ++++++++++++++++++-------------
> 2 files changed, 121 insertions(+), 72 deletions(-)
>
>
> Summary over all repositories:
> 2 files changed, 121 insertions(+), 72 deletions(-)
>
> --
> Generated by git-murpp 0.8.1
>
>
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
>
>
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2025-12-10 14:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-26 13:34 Christian Ebner
2025-11-26 13:34 ` [pbs-devel] [PATCH proxmox-backup 1/4] GC: Move S3 delete list state and logic to a dedicated struct Christian Ebner
2025-11-26 13:34 ` [pbs-devel] [PATCH proxmox-backup 2/4] chunk store: rename and limit scope for chunk store iterator Christian Ebner
2025-11-26 13:34 ` [pbs-devel] [PATCH proxmox-backup 3/4] chunk store: invert chunk filename checks in " Christian Ebner
2025-11-26 13:34 ` [pbs-devel] [PATCH proxmox-backup 4/4] chunk store: return chunk extension and check for used marker Christian Ebner
2025-12-10 14:21 ` Fabian Grünbichler
2025-12-11 11:28 ` Christian Ebner
2025-12-10 14:18 ` Fabian Grünbichler [this message]
2025-12-11 15:39 ` [pbs-devel] superseded: [PATCH proxmox-backup 0/4] followups for garbage collection Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176537631743.371273.12867159169043875156@yuna.proxmox.com \
--to=f.gruenbichler@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox