From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: pbs-devel@lists.proxmox.com, Christian Ebner <c.ebner@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup] garbage collection: allow to abort or shutdown on phase 2 for s3 stores
Date: Wed, 10 Dec 2025 12:12:16 +0100 [thread overview]
Message-ID: <176536513085.143405.17946544736654930665.b4-ty@proxmox.com> (raw)
In-Reply-To: <20251128154121.688870-1-c.ebner@proxmox.com>
On Fri, 28 Nov 2025 16:41:21 +0100, Christian Ebner wrote:
> Currently only phase 1 and phase 3 can be aborted on s3 backed
> datastores.
>
> Safely abort phase 2 after each processed s3 object key. Doing that
> after each key is possible since the chunk is already cleaned up from
> the local datastore cache after each iteration. While it might not
> have been cleaned up from the s3 backend, this leaves it in the same
> state as if after a datastore re-creation from previous S3 contents,
> where the local marker is also not present. So either the chunk will
> be cleaned up by the subsequent garbage collection run or overwritten
> by reupload and marker file re-insertion if a concurrent backup
> writer adds it again in the meantime.
>
> [...]
Applied, thanks!
[1/1] garbage collection: allow to abort or shutdown on phase 2 for s3 stores
commit: 5e3f7e26a70d13f801d50cd968bff9da2d2ef54f
Best regards,
--
Fabian Grünbichler <f.gruenbichler@proxmox.com>
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2025-12-10 11:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-28 15:41 [pbs-devel] " Christian Ebner
2025-12-10 11:12 ` Fabian Grünbichler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176536513085.143405.17946544736654930665.b4-ty@proxmox.com \
--to=f.gruenbichler@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox