From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, pbs-devel@lists.proxmox.com,
Yuki Sireneva <yuki.utk8g@gmail.com>
Subject: [pbs-devel] applied: [PATCH pve-xtermjs] Avoid allocating in `pre_exec` closure
Date: Tue, 9 Dec 2025 17:25:27 +0100 [thread overview]
Message-ID: <176529752385.73664.7588456303046408829.b4-ty@proxmox.com> (raw)
In-Reply-To: <20251205124802.334198-1-yuki.utk8g@gmail.com>
On Fri, 05 Dec 2025 12:47:50 +0000, Yuki Sireneva wrote:
> `Error::new` allocates memory (see [148971]). This is bad in
> multi-threaded programs, which pve-xtermjs AFAIK is. If the fork occurs
> while the allocator lock is held by another thread, deadlocks can occur,
> since there's no one left in the new process to unlock the mutex.
> I do not believe this is UB, and modern libc offer protections against
> this issue, but this isn't POSIX-compliant and should preferably be
> avoided.
>
> [...]
Applied, thanks!
[1/1] Avoid allocating in `pre_exec` closure
commit: 41051f5a5e7bce513a6e0e31cacea44cab988391
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2025-12-09 16:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-05 12:47 [pbs-devel] " Yuki Sireneva
2025-12-09 16:25 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176529752385.73664.7588456303046408829.b4-ty@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=yuki.utk8g@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox