From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup v2] etc: raise nofile soft limit for proxmox-backup-proxy
Date: Thu, 20 Nov 2025 14:02:26 +0100 [thread overview]
Message-ID: <1763643621.a39agi4muz.astroid@yuna.none> (raw)
In-Reply-To: <20251120092742.97147-1-c.ebner@proxmox.com>
On November 20, 2025 10:27 am, Christian Ebner wrote:
> Since commit 86d5d073 ("GC: fix race with chunk upload/insert on s3
> backends"), per-chunk file locks are acquired during phase 2 of
> garbage collection for datastores backed by s3 object stores. This
> however means that up to 1000 file locks might be held at once, which
> can result in the limit of open file handles to be reached.
>
> Therefore, bump the nolimit for the proxmox-backup-proxy in the systemd
> service unit, while keeping the hard limit as defined in
> /etc/systemd/system.conf.
>
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
> Changes since version 1:
> - Bumpt the limit directly in the systemd service unit
>
> etc/proxmox-backup-proxy.service.in | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/etc/proxmox-backup-proxy.service.in b/etc/proxmox-backup-proxy.service.in
> index 7ca806aa4..52ad99356 100644
> --- a/etc/proxmox-backup-proxy.service.in
> +++ b/etc/proxmox-backup-proxy.service.in
> @@ -10,6 +10,7 @@ Type=notify
> ExecStart=%LIBEXECDIR%/proxmox-backup/proxmox-backup-proxy
> ExecReload=/bin/kill -HUP $MAINPID
> PIDFile=/run/proxmox-backup/proxy.pid
> +LimitNOFILE=4096:524288
this change is not quite identical to the previous one though ;)
is 4k really enough? that means (not even) 4 GC runs, which could easily
happen with many datastores?
some sort of rationale why it's okay to do this would also be great,
after all there is a reason the default limit is so low..
> Restart=on-failure
> User=%PROXY_USER%
> Group=%PROXY_USER%
> --
> 2.47.3
>
>
>
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
>
>
>
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2025-11-20 13:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-20 9:27 Christian Ebner
2025-11-20 13:02 ` Fabian Grünbichler [this message]
2025-11-20 13:32 ` Christian Ebner
2025-11-20 14:32 ` Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1763643621.a39agi4muz.astroid@yuna.none \
--to=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox