From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup v2] etc: provide and enable mount unit for /run/proxmox-backup
Date: Thu, 20 Nov 2025 09:05:37 +0100 [thread overview]
Message-ID: <1763625888.t1wkdv7o75.astroid@yuna.none> (raw)
In-Reply-To: <20251119143148.9383-1-c.ebner@proxmox.com>
On November 19, 2025 3:31 pm, Christian Ebner wrote:
> Since the introduction of per-chunk file locks for datastores with s3
> backend, the inodes on the tmpfs backing /run/proxmox-backup might be
> to limited, the kernel dynamically calculating the limit based on
> available system memory [0]. To not limit the number of inodes,
> provide a systemd mount unit to create a dedicated tmpfs for
> /run/proxmox-backup.
>
> The mount unit is only enabled but not started by dh_installsystemd,
> so this has only effect after a reboot.
>
> [0] https://docs.kernel.org/filesystems/tmpfs.html
>
> Fixes: https://forum.proxmox.com/threads/176228/
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
Reviewed-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
> Changes since version 1 (thanks @Fabian):
> - Drop unneeded systemctl enable ...
> - Add comment for why the inodes are unlimited
> - Correctly set mountpoint uid:gid
>
> debian/proxmox-backup-server.install | 1 +
> "etc/run-proxmox\\x2dbackup.mount" | 14 ++++++++++++++
> 2 files changed, 15 insertions(+)
> create mode 100644 "etc/run-proxmox\\x2dbackup.mount"
>
> diff --git a/debian/proxmox-backup-server.install b/debian/proxmox-backup-server.install
> index d06f026cf..11dd037e8 100644
> --- a/debian/proxmox-backup-server.install
> +++ b/debian/proxmox-backup-server.install
> @@ -6,6 +6,7 @@ etc/proxmox-backup-daily-update.timer /usr/lib/systemd/system/
> etc/proxmox-backup-proxy.service /usr/lib/systemd/system/
> etc/proxmox-backup.service /usr/lib/systemd/system/
> etc/removable-device-attach@.service /usr/lib/systemd/system/
> +etc/run-proxmox\x2dbackup.mount /usr/lib/systemd/system/
> usr/bin/pmt
> usr/bin/pmtx
> usr/bin/proxmox-tape
> diff --git "a/etc/run-proxmox\\x2dbackup.mount" "b/etc/run-proxmox\\x2dbackup.mount"
> new file mode 100644
> index 000000000..cad35594d
> --- /dev/null
> +++ "b/etc/run-proxmox\\x2dbackup.mount"
> @@ -0,0 +1,14 @@
> +[Unit]
> +Description=Mount tmpfs at /run/proxmox-backup
> +Conflicts=umount.target
> +Before=local-fs.target umount.target
> +
> +[Mount]
> +Type=tmpfs
> +What=tmpfs
> +Where=/run/proxmox-backup
> +# Unlimited inodes as this stores per-chunk file locks
> +Options=rw,nosuid,nodev,noexec,relatime,uid=34,gid=34,nr_inodes=0,mode=755,inode64
one small nit: this could use `backup` instead of `34` (although it's
pretty much guaranteed to not matter, we do so in other parts of the
code base as well..)
> +
> +[Install]
> +WantedBy=local-fs.target
> --
> 2.47.3
>
>
>
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
>
>
>
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2025-11-20 8:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-19 14:31 Christian Ebner
2025-11-20 8:05 ` Fabian Grünbichler [this message]
2025-11-20 9:45 ` Christian Ebner
2025-11-20 10:06 ` [pbs-devel] superseded: " Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1763625888.t1wkdv7o75.astroid@yuna.none \
--to=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox