From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox] s3-client: make storage class in list objects v2 response optional
Date: Tue, 11 Nov 2025 15:15:18 +0100 [thread overview]
Message-ID: <1762870508.7srw3wyq2u.astroid@yuna.none> (raw)
In-Reply-To: <20251020091559.106203-1-c.ebner@proxmox.com>
thanks!
On October 20, 2025 11:15 am, Christian Ebner wrote:
> Some providers (e.g. Google cloud) do not include the storage class
> field in list objects v2 responses.
>
> Make the storage field optional, so response parsing does not fail if
> it is absent.
>
> Since the PBS S3 backend does not use this field, and is currently
> the only user of the crate, no further code adaptions are necessary.
>
> Reported-by: https://forum.proxmox.com/threads/173256/
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
> proxmox-s3-client/src/response_reader.rs | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/proxmox-s3-client/src/response_reader.rs b/proxmox-s3-client/src/response_reader.rs
> index afe501d5..bc01db6a 100644
> --- a/proxmox-s3-client/src/response_reader.rs
> +++ b/proxmox-s3-client/src/response_reader.rs
> @@ -92,7 +92,7 @@ pub struct ListObjectsV2Contents {
> /// Content size of object.
> pub size: u64,
> /// Storage class the object is stored on.
> - pub storage_class: String,
> + pub storage_class: Option<String>,
> }
>
> #[derive(Debug)]
> @@ -563,14 +563,14 @@ fn parse_list_objects_v2_response_test() {
> last_modified: LastModifiedTimestamp::from_str("2011-02-26T01:56:20.000Z").unwrap(),
> e_tag: "\"bf1d737a4d46a19f3bced6905cc8b902\"".to_string(),
> size: 10,
> - storage_class: "STANDARD".to_string(),
> + storage_class: Some("STANDARD".to_string()),
> },
> ListObjectsV2Contents {
> key: S3ObjectKey::try_from("/.cnt/key1").unwrap(),
> last_modified: LastModifiedTimestamp::from_str("2011-02-26T01:56:20.000Z").unwrap(),
> e_tag: "\"9b2cf535f27731c974343645a3985328\"".to_string(),
> size: 20,
> - storage_class: "STANDARD".to_string(),
> + storage_class: Some("STANDARD".to_string()),
> },
> ]
> );
> --
> 2.47.3
>
>
>
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
>
>
>
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2025-11-11 14:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-20 9:15 [pbs-devel] " Christian Ebner
2025-11-11 14:15 ` Fabian Grünbichler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1762870508.7srw3wyq2u.astroid@yuna.none \
--to=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox