[pbs-devel] [RFC proxmox-backup] datastore: drop unused get_chunk_iterator() method

* [pbs-devel] [RFC proxmox-backup] datastore: drop unused get_chunk_iterator() method
@ 2025-10-30 12:25 Christian Ebner
  2025-11-11 10:41 ` Fabian Grünbichler
  0 siblings, 1 reply; 2+ messages in thread
From: Christian Ebner @ 2025-10-30 12:25 UTC (permalink / raw)
  To: pbs-devel

Introduced by commit d59397e60e ("backup/datastore: expose
chunk_store.get_chunk_iterator"), this method was never used and
is dead code.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
Noticed while refactoring code in preparation for S3 per-chunk file
locking.

Could not find any codepath that is and was ever actively using this,
maybe that was never publicly exposed and only used during early
development phase in the proxmox-protocol, which was imported to
proxmox-backup repo a bit later.

 pbs-datastore/src/datastore.rs | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/pbs-datastore/src/datastore.rs b/pbs-datastore/src/datastore.rs
index 038306166..c83b9d754 100644
--- a/pbs-datastore/src/datastore.rs
+++ b/pbs-datastore/src/datastore.rs
@@ -512,15 +512,6 @@ impl DataStore {
         })
     }
 
-    pub fn get_chunk_iterator(
-        &self,
-    ) -> Result<
-        impl Iterator<Item = (Result<proxmox_sys::fs::ReadDirEntry, Error>, usize, bool)>,
-        Error,
-    > {
-        self.inner.chunk_store.get_chunk_iterator()
-    }
-
     // Requires obtaining a shared chunk store lock beforehand
     pub fn create_fixed_writer<P: AsRef<Path>>(
         &self,
-- 
2.47.3



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread