From: Dietmar Maurer <dietmar@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup 1/4] api2/types/userid: make Userid updatable
Date: Fri, 5 Mar 2021 13:02:15 +0100 (CET) [thread overview]
Message-ID: <1761070268.558.1614945736465@webmail.proxmox.com> (raw)
In-Reply-To: <20210305084532.19550-2-d.csapak@proxmox.com>
instead, I avoid using Updatable for now ...
> On 03/05/2021 9:45 AM Dominik Csapak <d.csapak@proxmox.com> wrote:
>
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> src/api2/types/userid.rs | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/api2/types/userid.rs b/src/api2/types/userid.rs
> index 7c73e69f..3b47ccdf 100644
> --- a/src/api2/types/userid.rs
> +++ b/src/api2/types/userid.rs
> @@ -30,7 +30,7 @@ use lazy_static::lazy_static;
> use serde::{Deserialize, Serialize};
>
> use proxmox::api::api;
> -use proxmox::api::schema::{ApiStringFormat, Schema, StringSchema};
> +use proxmox::api::schema::{ApiStringFormat, Schema, StringSchema, Updatable};
> use proxmox::const_regex;
>
> // we only allow a limited set of characters
> @@ -393,7 +393,7 @@ impl<'a> TryFrom<&'a str> for &'a TokennameRef {
> }
>
> /// A complete user id consisting of a user name and a realm
> -#[derive(Clone, Debug, PartialEq, Eq, Hash)]
> +#[derive(Clone, Debug, PartialEq, Eq, Hash, Updatable)]
> pub struct Userid {
> data: String,
> name_len: usize,
> --
> 2.20.1
>
>
>
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2021-03-05 12:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-05 8:45 [pbs-devel] [PATCH proxmox-backup 0/4] add notify-user to tape backup/restore Dominik Csapak
2021-03-05 8:45 ` [pbs-devel] [PATCH proxmox-backup 1/4] api2/types/userid: make Userid updatable Dominik Csapak
2021-03-05 12:02 ` Dietmar Maurer [this message]
2021-03-05 8:45 ` [pbs-devel] [PATCH proxmox-backup 2/4] config/tape_job: add notify-user config to tape jobs Dominik Csapak
2021-03-05 12:02 ` [pbs-devel] applied: " Dietmar Maurer
2021-03-05 8:45 ` [pbs-devel] [PATCH proxmox-backup 3/4] api2/tape: add notify_user to backup(-jobs) and restore api calls Dominik Csapak
2021-03-05 12:03 ` Dietmar Maurer
2021-03-05 8:45 ` [pbs-devel] [PATCH proxmox-backup 4/4] ui: tape: add notify-user fields Dominik Csapak
2021-03-05 12:02 ` [pbs-devel] applied: " Dietmar Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1761070268.558.1614945736465@webmail.proxmox.com \
--to=dietmar@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox