[pbs-devel] partially-applied: [PATCH proxmox-backup v2 00/12] s3 store: fix issues with chunk s3 backend upload and cache eviction

["Fabian Grünbichler" <f.gruenbichler@proxmox.com>]

On Wed, 08 Oct 2025 17:21:13 +0200, Christian Ebner wrote:
> These patches fix 2 issues with the current s3 backend implementation
> and reduce code duplication.
> 
> Patch 1 to 3 rework the garbage collection, deduplicating the common atime
> check and garbage collection status update logic and marks the chunk removal
> function signature as unsafe, as this requires specific pre-conditions.
> 
> [...]

Applied the first 8 patches, thanks:

[01/12] datastore: gc: inline single callsite method
        commit: a9e25866aa8a91e21e9d7cff8ebb3a1d933484e4
[02/12] gc: chunk store: rework atime check and gc status into common helper
        commit: 4dc6f5dcf48fb89b401abc6c11f7e4a64c955fff
[03/12] chunk store: add unsafe signature to cache remove method
        commit: 6951280989d009ac3fefd5023ebf835a1deb1f49
[04/12] local store cache: replace evicted cache chunks instead of truncate
        commit: 4ed3710556defb71245055c35e0e577ec895b6bb
[05/12] local store cache: serve response fetched from s3 backend
        commit: 9f9792612a56e8663c57a44071a4ebb1dc1e501f
[06/12] local store cache: refactor fetch and insert of chunks for s3 backend
        commit: 0ba88fa2b314f5b6280a5cda01e1c8395581be88
[07/12] local store cache: rework access cache fetching and insert logic
        commit: 94657440a800864550ee924f7bf5db51d3186041
[08/12] local store cache: drop obsolete cacher implementation
        commit: d37dbabed6f127f5a14f203f2214fbf22f32a229

Left these for for further rework:

[09/12] chunk store: refactor method for chunk insertion
[10/12] api: chunk upload: fix race between chunk backend upload and insert
[11/12] api: chunk upload: fix race with garbage collection for no-cache on s3
[12/12] pull: guard chunk upload and only insert into cache after upload

Best regards,
-- 
Fabian Grünbichler <f.gruenbichler@proxmox.com>


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel