From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pbs-devel@lists.proxmox.com, Christian Ebner <c.ebner@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox] sync: pull: fix regression in resync of corrupt snapshots
Date: Mon, 22 Sep 2025 20:09:51 +0200 [thread overview]
Message-ID: <175856458770.2599639.14751015128507545973.b4-ty@proxmox.com> (raw)
In-Reply-To: <20250917102957.231963-1-c.ebner@proxmox.com>
On Wed, 17 Sep 2025 12:29:57 +0200, Christian Ebner wrote:
> In commit eea1176f ("pull: refactor source snapshot list filtering
> logic") the filtering of snapshots to be synced when pulling from the
> source datastore was split in preparation for correct pre-filtering
> of the snapshot when the verified-only or encrypted-only flags have
> been set.
>
> This however introduced a regression, as previously also snapshots
> older than the newest snapshot on the target were included in the
> list, if the `resync_corrupt` parameter is set and the corresponding
> target snapshot failed verification or the loading of the manifest to
> check this failed, now however being filtered out unconditionally.
>
> [...]
Applied, thanks!
[1/1] sync: pull: fix regression in resync of corrupt snapshots
commit: 2fb481c4432f890612d9b0cd684c050ccb72ad2f
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2025-09-22 18:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-17 10:29 [pbs-devel] " Christian Ebner
2025-09-17 13:41 ` Christian Ebner
2025-09-18 6:45 ` Hannes Laimer
2025-09-22 18:09 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175856458770.2599639.14751015128507545973.b4-ty@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox