From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, pbs-devel@lists.proxmox.com,
Christian Ebner <c.ebner@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox 0/3] s3 client: improve error logging for invalid requests
Date: Wed, 23 Jul 2025 13:51:30 +0200 [thread overview]
Message-ID: <175327148852.3477787.16131019408240753960.b4-ty@proxmox.com> (raw)
In-Reply-To: <20250723102601.495806-1-c.ebner@proxmox.com>
On Wed, 23 Jul 2025 12:25:58 +0200, Christian Ebner wrote:
> This patches improve error logging by refactoring the logging logic
> into a common helper and also covering responses with response status
> BAD_REQUEST. This has not been covered previously and helps to
> diagnose the reason for the bad request. In example, a malformed
> request might return the following response body:
>
> ```
> <?xml version="1.0" encoding="UTF-8"?>
> <Error>
> <Code>MalformedXML</Code>
> <Message>The XML you provided was not well formed or did not validate against our published schema.</Message>
> </Error>
> ```
>
> [...]
Applied, thanks!
[1/3] s3 client: fix minor whitespace issue
commit: 808b3725b63f82caf5fb49678593f7cf0aad1549
[2/3] s3 client: refactor error response body into dedicated helper
commit: d63fe256beb4c961ea1258cb114c12b2cc4a3b0e
[3/3] s3 client: log error response body for invalid request status codes
commit: 093dfeb8206aa3db405e27be92411794bcfc8780
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2025-07-23 11:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-23 10:25 [pbs-devel] " Christian Ebner
2025-07-23 10:25 ` [pbs-devel] [PATCH proxmox 1/3] s3 client: fix minor whitespace issue Christian Ebner
2025-07-23 10:26 ` [pbs-devel] [PATCH proxmox 2/3] s3 client: refactor error response body into dedicated helper Christian Ebner
2025-07-23 10:26 ` [pbs-devel] [PATCH proxmox 3/3] s3 client: log error response body for invalid request status codes Christian Ebner
2025-07-23 11:31 ` [pbs-devel] [PATCH proxmox 0/3] s3 client: improve error logging for invalid requests Lukas Wagner
2025-07-23 11:51 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175327148852.3477787.16131019408240753960.b4-ty@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox