public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: pbs-devel@lists.proxmox.com, Christian Ebner <c.ebner@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup] datastore: snapshot iterator: avoid unnecessary string conversion
Date: Wed, 30 Apr 2025 14:31:55 +0200	[thread overview]
Message-ID: <174601627468.468292.3531359337593665696.b4-ty@proxmox.com> (raw)
In-Reply-To: <20250429130917.401351-1-c.ebner@proxmox.com>


On Tue, 29 Apr 2025 15:09:17 +0200, Christian Ebner wrote:
> Avoid converting the backup time string to the timestamp and back to
> string again. `BackupDir::with_rfc3339` already performs the string
> to time conversion, so use it over parsing the timestamp first only
> to convert it back to string in `BackupDir::with_group`.
> 
> No functional changes intended.
> 
> [...]

Applied, thanks!

[1/1] datastore: snapshot iterator: avoid unnecessary string conversion
      commit: dc324716a688a67d700fa133725740ac5d3795ce

Best regards,
-- 
Fabian Grünbichler <f.gruenbichler@proxmox.com>


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

      reply	other threads:[~2025-04-30 12:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-29 13:09 [pbs-devel] " Christian Ebner
2025-04-30 12:31 ` Fabian Grünbichler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=174601627468.468292.3531359337593665696.b4-ty@proxmox.com \
    --to=f.gruenbichler@proxmox.com \
    --cc=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal