From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pbs-devel@lists.proxmox.com, Dominik Csapak <d.csapak@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup] tape: wait for calibration of LTO-9 tapes
Date: Wed, 16 Apr 2025 14:56:17 +0200 [thread overview]
Message-ID: <174480781987.1433073.861145140295426472.b4-ty@proxmox.com> (raw)
In-Reply-To: <20250415114043.2389789-1-d.csapak@proxmox.com>
On Tue, 15 Apr 2025 13:40:43 +0200, Dominik Csapak wrote:
> Since LTO-9, initial loading of tapes into a drive can block up to 2
> hours according to the spec. In case we run into a ready check timeout,
> query the drive, and increase the timeout to 2 hours and 5 minutes if
> it's calibrating (5 minutes headroom).
>
>
Applied, thanks! I extended the commit message with the follow-up info you
provided and also referenced the commit that implemented the longer
timeout for the format procedure.
btw. there is a theoretical case where one could call this method with a
timeout greater than your fallback and the tape needing even longer than
normal, in that case we would do an extra checking round before decreasing
the timeout and then bail on the next round, so not even problematic, just
might be a bit odd on debugging in the very unlikely case this happens in
the first place. That said, a doc-comment for the method and maybe even a
check if the original timeout parameter is already longer than 2h5m would
not exactly hurt and clarify this. But if that makes even sense it really
can be done as a follow up.
[1/1] tape: wait for calibration of LTO-9 tapes
commit: 07a21616c28a09efb6039e79163b9c4ac8610565
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2025-04-16 12:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-15 11:40 [pbs-devel] " Dominik Csapak
2025-04-15 15:51 ` Thomas Lamprecht
2025-04-16 6:22 ` Dominik Csapak
2025-04-16 12:56 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174480781987.1433073.861145140295426472.b4-ty@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal